Merged accounts are left behind with cached karma totals
Bug #190242 reported by
Guilherme Salgado
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Unassigned | ||
Bug Description
When merging accounts we move all the karma entries from one person to the other but we don't do the same for the cached karma totals (KarmaCache and KarmatotalCache tables). This is a problem because the script which updates these caches doesn't delete nor update them because the merged accounts have no karma entries.
We should either change the code which merges people to delete the cache or change the script to delete the ones for merged accounts. I prefer the former, I think.
Related branches
lp:~sinzui/launchpad/merge-karma-1
- Aaron Bentley (community): Approve
-
Diff: 259 lines (+147/-30)3 files modifieddatabase/schema/security.cfg (+2/-2)
lib/lp/registry/model/person.py (+46/-3)
lib/lp/registry/tests/test_person.py (+99/-25)
| Changed in launchpad: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| affects: | launchpad-foundations → launchpad-registry |
| Changed in launchpad-registry: | |
| importance: | Medium → Low |
| tags: | added: merge-deactivate |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| Changed in launchpad-registry: | |
| milestone: | none → 10.11 |
| importance: | Low → High |
| Changed in launchpad-registry: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
This behaviour creates 404s since the merge profile is still linked in Top Contributors (bug 660475). This is a high bug.