request expired being raised does not increase the opstats timeout count

Bug #636804 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Colin Watson

Bug Description

Failure in test lib/canonical/launchpad/pagetests/standalone/xx-opstats.txt
Traceback (most recent call last):
  File "/usr/lib/python2.6/unittest.py", line 279, in run
    testMethod()
  File "/usr/lib/python2.6/doctest.py", line 2152, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for xx-opstats.txt
  File "lib/canonical/launchpad/pagetests/standalone/xx-opstats.txt", line 0

----------------------------------------------------------------------
File "lib/canonical/launchpad/pagetests/standalone/xx-opstats.txt", line 183, in xx-opstats.txt
Failed example:
    report()
Differences (ndiff with -expected +actual):
      503s: 1
      5XXs: 1
      http requests: 1
      requests: 1
    - timeouts: 1

This occurs if the timeout tracer starts raising RequestExpired rather than TimeoutError, because the *tracer* does the opstats incrementing, rather than publication machinery.

I'm fixing this specific example by catching both exceptions, but other timeouts like the google search service timeout are probably not being recorded accurately.

Related branches

Gary Poster (gary)
Changed in launchpad-foundations:
importance: Undecided → Medium
status: New → Triaged
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
summary: - request expired being raised does not increased the opstats timeout
- count
+ request expired being raised does not increase the opstats timeout count
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.