memcache cache keys interact poorly with query parameters
Bug #634326 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Stuart Bishop | ||
Bug Description
If you look at https:/
You'll see cache keys like:
pt:lpnet:
These are for bug comments which are rendered the same way on bug index and on bugindex?
Is there a way for the template to say that the key should not contain this?
Related branches
lp:~stub/launchpad/memcache
- Brad Crittenden (community): Approve (code)
-
Diff: 207 lines (+82/-14)3 files modifiedlib/lp/services/memcache/doc/tales-cache.txt (+52/-5)
lib/lp/services/memcache/tales.py (+26/-7)
lib/lp/services/memcache/tests/test_doc.py (+4/-2)
Revision history for this message
| Stuart Bishop (stub) wrote | #1 |
Revision history for this message
| Gary Poster (gary) wrote | #2 |
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| importance: | Low → High |
| assignee: | nobody → Stuart Bishop (stub) |
| Changed in launchpad-foundations: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-foundations: | |
| milestone: | none → 10.11 |
| tags: | added: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
Revision history for this message
| Robert Collins (lifeless) wrote | #5 |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This sounds like a good idea, and simple enough at the Python end. We need to decide on the syntax for the TALES - we need to support our use cases without becoming unwieldy. I expect this will need an extra parameter - I don't think we can sanely overload any of the existing parameters.