propertycache adaption failures in test suite
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Gavin Panella | ||
Bug Description
There is an adapter, get_default_cache, in lp.services.
from Interface to IPropertyCache. It is registered directly with the
global site manager at import time and via ZCML (see
lib/lp/
However, when trying to land
lp:~allenap/launchpad/cache-experiment-roll-out via EC2 there are
about 10 adaption failures:
TypeError: ('Could not adapt',
<lp.archivepu
<InterfaceClass lp.services.
The failing tests pass when run directly. I doubt there is any issue
attributable to the EC2 environment; rather I think that there is some
Zope-ish weirdness when running the full test suite.
The attached file, cache-experimen
full log of the test run.
Related branches
- Henning Eggers (community): Approve (code)
-
Diff: 874 lines (+114/-189)22 files modifiedlib/canonical/database/sqlbase.py (+2/-2)
lib/lp/bugs/doc/externalbugtracker-mantis-csv.txt (+2/-2)
lib/lp/bugs/model/bug.py (+8/-8)
lib/lp/bugs/model/bugtask.py (+3/-3)
lib/lp/registry/browser/person.py (+6/-6)
lib/lp/registry/doc/personlocation.txt (+2/-2)
lib/lp/registry/doc/teammembership.txt (+2/-2)
lib/lp/registry/model/distribution.py (+2/-2)
lib/lp/registry/model/distroseriesdifference.py (+4/-3)
lib/lp/registry/model/person.py (+15/-15)
lib/lp/registry/model/product.py (+2/-3)
lib/lp/registry/tests/test_distribution.py (+2/-2)
lib/lp/registry/tests/test_distroseriesdifference.py (+2/-2)
lib/lp/services/configure.zcml (+0/-3)
lib/lp/services/doc/propertycache.txt (+32/-19)
lib/lp/services/propertycache.py (+19/-102)
lib/lp/shipit.py (+1/-3)
lib/lp/soyuz/model/archive.py (+2/-2)
lib/lp/soyuz/model/distroseriesbinarypackage.py (+2/-2)
lib/lp/testing/factory.py (+3/-3)
lib/lp/testopenid/browser/server.py (+2/-2)
utilities/sourcedeps.conf (+1/-1)
| Gavin Panella (allenap) wrote | #1 |
| tags: | added: tech-debt |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Gavin Panella (allenap) |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| Changed in launchpad-foundations: | |
| milestone: | none → 10.11 |
| tags: | added: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-foundations: | |
| importance: | Undecided → High |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
Fixed in stable r11793 <http://