launchpad api clients have to poll to find out when an oauth token has been handed out

Bug #607418 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

As a follow-on from <https://code.edge.launchpad.net/~leonardr/launchpadlib/improve-workflow/+merge/29849>

It might be nice if Launchpad let a client use a long GET <http://en.wikipedia.org/wiki/Comet_(programming)> to find out when the user has accepted an OAuth request, rather than the client polling. (One neat side effect is that this would pretty much just work with the existing launchpadlib client code, which would block in its first request.)

Getting there requires a few nontrivial changes:
 * launchpad appservers and front ends must be able to cheaply support long-lived requests, by extending their timeout and having reasonably-cheap per-request state
 * once the cookie is accepted, a message needs to be sent to the http server to tell it to reply to the client. (there seems little point in polling internally.)

In my opinion this is not a very compelling case for it, because OAuth granting is infrequent and not performance-critical. However, Robert asked me to file it. :_)

Revision history for this message
Gary Poster (gary) wrote :

If Robert hadn't asked for it, I'd say this was a a Won't Fix.

Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Robert Collins (lifeless) wrote :

Indeed, I'm pretty sure its a huge pile of work right now and totally infeasible. I do want us to have a picture of the places that long poll / comet etc can be useful - at some point we're going to have to cross that bridge, even though we have many more important fish to fry today.

Changed in launchpad-foundations:
importance: Low → Wishlist
tags: added: nopolling
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 607418] Re: launchpad should notify when oauth is accepted using long GET

Perhaps this bug would be better as "we should support long GET" and
then it can list places where it would be useful.

To me the most obvious place would be in letting objects dynamically
update within pages, which is where it seems to be most commonly used
by other people. For instance it might be useful to see builds
dynamically updating in a soyuz page, or seeing when other people
comment on a bug while you have it open, or getting a continuous long
feed in an API client of changed objects. But even then this is so
far down the list that I don't know why I'm even posting.... :)

summary: - launchpad should notify when oauth is accepted using long GET
+ launchpad api clients have to poll to find out when an oauth token has
+ been handed out
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Wishlist → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.