API Pageid for collections is 'scopedcollection:collectionresource' which does not mention the origin page id
Bug #606184 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Diogo Matsubara | ||
Bug Description
e.g. in Lpnet Errors for 2010-07-15
=== Top 10 Time Out Counts by Page ID ===
Hard / Soft Page ID
142 / 139 ScopedCollectio
its very unclear that this is a (in this case) bugs/attachment API call. I am guessing, but I suspect errorlog.py isn't generating an appropriate pageid (and am also guessing that that would be a good place to fix it, as it keeps the complexity constrained to the generator, rather than the processor of the data - the generator knows the code that is actually executing, after all).
Fixing this would make OOPS reports that include such timeouts easier for domain teams to drill down into and fix.
Thanks,
Rob
Related branches
lp:~matsubara/launchpad/bug-606184-pageid-for-collections
- Gary Poster (community): Approve
-
Diff: 93 lines (+50/-2)2 files modifiedlib/canonical/launchpad/webapp/servers.py (+18/-1)
lib/canonical/launchpad/webapp/tests/test_pageid.py (+32/-1)
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| assignee: | nobody → Diogo Matsubara (matsubara) |
| summary: |
- oops reports contain 'scopedcollection:collectionresource' which is hard - to debug/easy to ignore + API Pageid for collections is 'scopedcollection:collectionresource' + which does not mention the origin page id |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
Revision history for this message
| Gary Poster (gary) wrote | #2 |
| Changed in launchpad-foundations: | |
| status: | Triaged → In Progress |
| milestone: | none → 10.09 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Robert Collins (lifeless) wrote | #4 |
Revision history for this message
| Robert Collins (lifeless) wrote | #5 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hey Diogo, just thought I'd ping to see how this is going; I know its huge in the scheme of things, but it would make a real difference to the page performance report and to the oops reports to have the actual collection being traversed be more obvious.