Test lib/lp/registry/tests/../stories/foaf/xx-resetpassword-of-sso-account.txt fails if canonical-identity-provider absent

Bug #471724 reported by Max Bowsher
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Guilherme Salgado

Bug Description

The new test lib/lp/registry/tests/../stories/foaf/xx-resetpassword-of-sso-account.txt fails for me. I infer from the manner of the failure (ComponentLookupError: (<InterfaceClass canonical.launchpad.interfaces.authtoken.IAuthTokenSet>, '') in getUtility) and the fact it made it into stable fine that it is depending on canonical-identity-provider being present - which is a bit of a downer for community members running the testsuite.

Gary Poster (gary)
Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Guilherme Salgado (salgado)
Revision history for this message
Guilherme Salgado (salgado) wrote :

We could add some infrastructure to have certain tests run only when c-i-p is available, move the test to c-i-p or trim it so that it only shows that it's possible to start the password-reset workflow from launchpad.net.

Since the test was actually written to show that a user can request a password reset of a personless account from launchpad.net and the fact that the last step of resetting a password is already tested in c-i-p, we could safely trim the test without losing any test coverage. Or we might comment out the bits that depend on c-i-p until we can mark some tests to run only when it's available.

Revision history for this message
Max Bowsher (maxb) wrote :

From a community developer's point of view, it would absolutely suck to have to remember a list of tests which always give false failures.

Changed in launchpad-foundations:
status: Triaged → In Progress
Changed in launchpad-foundations:
status: In Progress → Fix Committed
milestone: none → 10.02
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.