Launchpad itself

Add a helper function to get the canonical_url of an object in a format suitable for Windmill tests

Bug #456773 reported by Eleanor Berger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Paul Hummer

Bug Description

The URLs of Launchpad objects when using Windmill are slightly different - they use http instead of https, and the server is accessed on port 8085. In order to be able to use canonical_url in such tests, we need to extend it to take the scheme and port as parameters.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Why do you need canonical_url in windmill tests? I don't really see the need to extend the signature of canonical_url. Why not simply add a helper in the test suite that would normalise the output of canonical_url for the windmill specific env?

Changed in launchpad-foundations:
status: New → Incomplete
Revision history for this message
Eleanor Berger (intellectronica) wrote :

Yes, after discussing this with Aaron again I've also come to the conclusion that a substitute function for tests is a better solution.

Changed in launchpad-foundations:
status: Incomplete → Triaged
summary: - Make canonical_url work nicely in Windmill tests
+ Add a helper function to get the canonical_url of an object in a format
+ suitable for Windmill tests
Revision history for this message
Björn Tillenius (bjornt) wrote :

Paul fixed this by modifying the config for the Windmill test layer.

Changed in launchpad-foundations:
status: Triaged → Fix Released
assignee: nobody → Paul Hummer (rockstar)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.