Launchpad itself

Zope sleeps during redirects

Bug #401586 reported by Jeroen T. Vermeulen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gary Poster

Bug Description

The notfound-traversals.txt test spends most of its time sitting idle, typically about 8 minutes.

The offender is zope.publisher.http.HTTPRequest.supportsRetry, which does a conditional time.sleep(). A global Boolean variable in that module, STAGGER_RETRIES, controls this.

If we can set this variable to False while running pagetests, we'll save some time on this test (in the case I timed, the difference between 8 minutes 40 seconds and a mere 58 seconds) and presumably the rest of the pagetests as well.

Related branches

lp:~jml/launchpad/staggering-bug-401586
Stuart Bishop (community): Approve
Diff: None lines
Jonathan Lange (jml)
Changed in launchpad:
assignee: nobody → Jonathan Lange (jml)
importance: Undecided → High
status: New → In Progress
Diogo Matsubara (matsubara)
affects: launchpad → launchpad-foundations
tags: added: test-system
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8989.

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Gary Poster (gary) wrote : Re: Zope sleeps during tests

This was identified upstream as a misfeature for the entire zope publisher (not just testing). zope.publisher 3.5.8 and trunk no longer have the "staggering" behavior here. The lp:~gary/launchpad/zbuildout branch, which moves us to zope distributions via buildout, will include 3.5.8, and remove the changes from lp:~jml/launchpad/staggering-bug-401586 .

Jonathan Lange (jml)
tags: added: build-infrastructure
removed: test-system
Gary Poster (gary)
Changed in launchpad-foundations:
status: Fix Committed → New
Revision history for this message
Gary Poster (gary) wrote :

To be clear, this affects production as well.

Perhaps opening a new bug would be appropriate, but I should record the saga of me trying to fix it somewhere.

I made a zope.publisher 3.5.8 and tried to put it in Launchpad. It turns out that 3.5.7 had introduced an incompatible change (! :-( ) that meant that we could not use it, or 3.5.8, without subsequent changes.

I reinstated Jono's changes. Now we need to make a new zope.publisher without the backwards incompatibility and try again.

Gary Poster (gary)
summary: - Zope sleeps during tests
+ Zope sleeps during redirects
Changed in launchpad-foundations:
status: New → Confirmed
assignee: Jonathan Lange (jml) → Gary Poster (gary)
assignee: Gary Poster (gary) → nobody
Revision history for this message
Jonathan Lange (jml) wrote :

Looks like we're using zope.publisher 3.10 now, and thus we should be avoiding the staggering thing. I'm marking this bug as fix released. Please re-open it if I'm mistaken.

Changed in launchpad-foundations:
assignee: nobody → Gary Poster (gary)
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.