code browser should use oops system

Bug #84838 reported by Tim Penhey
20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Andrew Bennetts

Bug Description

The new codebrowser app needs to hook into the oops system so we can track timeouts or 404s.

This would allow:
 * trusted developers to retrieve the reports
 * giving a handle to users who experience a timeout or crash
 * perhaps easier summarizing of failures

mwhudson says they currently go "into the debug.log" so presumably one needs a losa to look at them.

Related branches

Tim Penhey (thumper)
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
James Henstridge (jamesh) wrote :

Given that loggerhead is built on top of a completely different web framework, this is non-trivial.

Revision history for this message
James Henstridge (jamesh) wrote :

Secondly, the way we trap timeouts in Launchpad (in the database adapter code) is not really appropriate for Loggerhead, since it doesn't issue database queries.

Revision history for this message
Martin Pool (mbp) wrote :

Leaving aside timeouts, is it really hard to put a traceback into the oops system? I understood that the recent cleanups by ddaa now mean it's separated from zope and can be just called with a traceback from any script..

(I guess you just said non-trivial, not "hard".)

Revision history for this message
David Allouche (ddaa) wrote :

The oops system is still dependent on the canonical.config system. Otherwise, it is not _really_ dependent on zope, for example it is used by the branch scanner which is a non-zope script.

Probably, the biggest problem here is to find a place in loggerhead to hook into to record exceptions. Details on how to report oopses from non-zope systems can be found on https://launchpad.canonical.com/ErrorReportManagementForScripts.

Changed in launchpad-bazaar:
assignee: nobody → mwhudson
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Now that loggerhead is wsgi based, I'm sure we can write some OOPS-reporting middleware.

Martin Pool (mbp)
description: updated
Changed in launchpad-code:
assignee: Michael Hudson (mwhudson) → nobody
Revision history for this message
Andrew Bennetts (spiv) wrote :

I have a patch that adds a basic OOPS WSGI middleware to codebrowse. (I did most of it at the Epic, but didn't get around to making it functional until now.) Will put it in code review shortly.

Changed in launchpad-code:
assignee: nobody → Andrew Bennetts (spiv)
status: Triaged → In Progress
Revision history for this message
Andrew Bennetts (spiv) wrote :

The patch has landed, but still lacks the production config values. I've just mailed losas@ asking for what they should be.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad-code:
status: In Progress → Fix Committed
milestone: none → 10.08
Changed in launchpad-code:
milestone: 10.08 → 10.09
Paul Hummer (rockstar)
tags: added: qa-untestable
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.