Certain error tracebacks can leak through codehosting
Bug #675517 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Ian Booth | ||
Bug Description
Recently, there was an incident where people who pushed to Launchpad were getting tracebacks displayed on their command line. (See bug 674305). The root cause of that traceback is being addressed elsewhere. However, the very fact that a traceback was displayed rather than an OOPS ID shows that there is also a bug in our error handling.
We should fix that bug, so that we never show ugly tracebacks to the user ever again.
Related branches
lp:~wallyworld/launchpad/codehost-error-trackback-leak
- Tim Penhey (community): Approve
- Graham Binns (community): Approve (code)
-
Diff: 367 lines (+183/-11)4 files modifiedlib/canonical/launchpad/xmlrpc/faults.py (+17/-2)
lib/lp/codehosting/puller/tests/test_scheduler.py (+0/-1)
lib/lp/codehosting/vfs/branchfs.py (+51/-7)
lib/lp/codehosting/vfs/tests/test_branchfs.py (+115/-1)
| Changed in launchpad-code: | |
| assignee: | nobody → Ian Booth (wallyworld) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
To post a comment you must log in.
Fixed in stable r12079 <http://