Email should not be sent for new WIP merge proposals
Bug #624009 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey | ||
Bug Description
If I create a merge proposal and uncheck the "ready for review" box, an email is still sent out requesting a review. This has wasted people's time reviewing unfinished branches - the email should not be sent until the states moves to "ready".
Related branches
lp:~thumper/launchpad/rename-created-job
- Michael Hudson-Doyle: Approve
-
Diff: 331 lines (+57/-57)7 files modifiedlib/lp/code/configure.zcml (+5/-5)
lib/lp/code/interfaces/branchmergeproposal.py (+9/-9)
lib/lp/code/mail/tests/test_codehandler.py (+2/-2)
lib/lp/code/model/branchmergeproposaljob.py (+17/-18)
lib/lp/code/model/tests/test_branchmergeproposal.py (+2/-2)
lib/lp/code/model/tests/test_branchmergeproposaljobs.py (+19/-19)
lib/lp/code/subscribers/branchmergeproposal.py (+3/-2)
lp:~thumper/launchpad/needs-review-event
- Launchpad code reviewers: Pending requested
-
Diff: 221 lines (+49/-19)8 files modifiedlib/lp/code/configure.zcml (+4/-0)
lib/lp/code/event/branchmergeproposal.py (+7/-0)
lib/lp/code/interfaces/event.py (+5/-0)
lib/lp/code/model/branch.py (+6/-1)
lib/lp/code/model/tests/test_branchmergeproposal.py (+9/-7)
lib/lp/code/model/tests/test_codereviewcomment.py (+1/-1)
lib/lp/code/subscribers/branchmergeproposal.py (+8/-0)
lib/lp/testing/__init__.py (+9/-10)
lp:~thumper/launchpad/defer-wip-email
- Michael Hudson-Doyle: Approve
-
Diff: 190 lines (+64/-10)5 files modifiedlib/lp/code/doc/branch-merge-proposal-notifications.txt (+3/-2)
lib/lp/code/model/branch.py (+2/-1)
lib/lp/code/model/branchmergeproposal.py (+6/-0)
lib/lp/code/model/tests/test_branchmergeproposal.py (+48/-4)
lib/lp/code/model/tests/test_branchmergeproposaljobs.py (+5/-3)
| Changed in launchpad-code: | |
| status: | New → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
| importance: | Undecided → Medium |
| tags: | added: code-review email |
Revision history for this message
| Tim Penhey (thumper) wrote | #1 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote Re: [Bug 624009] Re: Email should not be sent for new WIP merge proposals | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Incremental fix | #3 |
| Changed in launchpad-code: | |
| milestone: | none → 10.11 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #5 |
Revision history for this message
| Tim Penhey (thumper) wrote | #6 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
In progress, but progress is slow as it isn't the top of the priority list.