Result of SPRBuild assumes distro build

So the problem is that these objects sometimes have canonical url and sometimes don't. Is that a situation we want to perpetuate?

If these objects sometimes don't have canonical urls, then canonical_url should not return a URL sometimes.

Otherwise, we should just make sure the objects have URLs, which should be mostly a ZCML change.

I'm finally getting back to this branch (my mistake) and I can't reproduce this at all. Michael, can you still reproduce this, and if so, please tell me how. My test seems to indicate that there is no link here. This is what my test looks like:

    def test_result_formatter(self):
        """SourcePackageRecipe results should not have a link."""
        build = self.makeRecipeBuild()
        build.queueBuild(build)
        release = self.factory.makeSourcePackageRelease(
            source_package_recipe_build=None)
        release.source_package_recipe_build = build
        transaction.commit()
        build_url = canonical_url(build)
        release_url = canonical_url(release)
        expected = str('%s in %s %s' % (
            release.name,
            release.upload_distroseries.distribution.bugtargetname,
            release.version))
        logout()

        browser = self.getUserBrowser(build_url, user=self.chef)
        result = find_tag_by_id(browser.contents, 'build-result')
        self.assertEqual(
            result.renderContents(),
            expected)

It returns a result that has no link at all. Reproduction instructions would be of help here.

So my test must just be incorrect, since I've reproduced this on edge. Some help here making a good test would be very helpful

After chatting to Paul, I think that "Result:" section makes no sense for recipe builds right now because PPAs don't have individual package pages.

So, you might as well just remove it and save the hassle here.

Playing in ec2 now.

In devel 11193

Fixed in stable r11193 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11193>.