'queued' merge proposals are unclear on +activereviews
Bug #561157 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Colin Watson | ||
Bug Description
I know this isn't polished yet, just noting the issues I encounter.
Marking a MP as 'queued' removes it from the 'approved proposals' section on +activereviews - which is reasonable. However it stays on that page and moves into 'other reviews I am not currently doing' - it would be better to show queued proposals in their own section, I think.
Related branches
lp:~cjwatson/launchpad/remove-branchmergequeue
- William Grant: Approve (code)
-
Diff: 3174 lines (+48/-2315)44 files modifieddatabase/schema/security.cfg (+0/-2)
lib/lp/_schema_circular_imports.py (+0/-6)
lib/lp/app/browser/tests/test_macro_view.py (+0/-1)
lib/lp/code/adapters/branch.py (+0/-1)
lib/lp/code/browser/branch.py (+1/-23)
lib/lp/code/browser/branchlisting.py (+2/-5)
lib/lp/code/browser/branchmergeproposal.py (+1/-185)
lib/lp/code/browser/branchmergequeue.py (+0/-81)
lib/lp/code/browser/branchmergequeuelisting.py (+0/-105)
lib/lp/code/browser/configure.zcml (+0/-65)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+3/-16)
lib/lp/code/browser/tests/test_branchmergequeue.py (+0/-121)
lib/lp/code/browser/tests/test_branchmergequeuelisting.py (+0/-229)
lib/lp/code/configure.zcml (+2/-31)
lib/lp/code/doc/branchmergeproposal.txt (+0/-13)
lib/lp/code/errors.py (+0/-10)
lib/lp/code/interfaces/branch.py (+1/-49)
lib/lp/code/interfaces/branchmergeproposal.py (+7/-43)
lib/lp/code/interfaces/branchmergequeue.py (+0/-129)
lib/lp/code/interfaces/branchmergequeuecollection.py (+0/-62)
lib/lp/code/interfaces/webservice.py (+1/-5)
lib/lp/code/model/branch.py (+1/-24)
lib/lp/code/model/branchmergeproposal.py (+13/-92)
lib/lp/code/model/branchmergequeue.py (+0/-88)
lib/lp/code/model/branchmergequeuecollection.py (+0/-158)
lib/lp/code/model/tests/test_branch.py (+0/-58)
lib/lp/code/model/tests/test_branchmergeproposal.py (+14/-120)
lib/lp/code/model/tests/test_branchmergequeue.py (+0/-155)
lib/lp/code/model/tests/test_branchmergequeuecollection.py (+0/-194)
lib/lp/code/stories/webservice/xx-branch.txt (+0/-2)
lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+0/-8)
lib/lp/code/templates/branch-pending-merges.pt (+0/-12)
lib/lp/code/templates/branchmergeproposal-pagelet-summary.pt (+0/-18)
lib/lp/code/templates/branchmergequeue-index.pt (+0/-39)
lib/lp/code/templates/branchmergequeue-listing.pt (+0/-68)
lib/lp/code/templates/branchmergequeue-macros.pt (+0/-20)
lib/lp/code/templates/person-codesummary.pt (+0/-5)
lib/lp/registry/browser/person.py (+0/-5)
lib/lp/registry/interfaces/person.py (+0/-3)
lib/lp/registry/model/person.py (+0/-7)
lib/lp/registry/personmerge.py (+2/-9)
lib/lp/security.py (+0/-13)
lib/lp/services/features/flags.py (+0/-6)
lib/lp/testing/factory.py (+0/-29)
| tags: | added: code-review confusing-ui merge-queues |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad: | |
| status: | Triaged → Invalid |
| status: | Invalid → Triaged |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-untestable |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually, checking the code, I think it hasn't been removed yet. Its unclear :(. Putting back to triaged.