"Review type" field is never enabled if you use keyboard only

Bug #496820 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tim Penhey

Bug Description

On edge, the "Review type" field is now below the comment box, and is theoretically only enabled if you elect to do a review. By default, a comment is only a comment and is not allowed to have a review type.

Steps to reproduce:
  * Find a code review
  * Type some stuff in the comment field
  * Hit "Tab"
  * Select "Approve" with the keyboard (i.e. hit the down arrow)
  * Hit "Tab"

What I expect:
  * The cursor to appear in the "Review type" input field, ready for me to enter a review type

What I see:
  * The "Save comment" button activated, the "Review type" input field disabled.

This bug exists on production, but it's much less obvious, probably since the "Review" pulldown box cannot be conveniently reached via keyboard navigation.

Related branches

Tim Penhey (thumper)
tags: added: confusing-ui current-rollout-blocker
Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → In Progress
milestone: none → 3.1.12
Tim Penhey (thumper)
Changed in launchpad-code:
status: In Progress → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.