imports disabled too rapidly
Bug #413637 reported by
Stuart Bishop
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Michael Hudson-Doyle | ||
Bug Description
Imports are automatically disabled after 5 failures, which is great. What isn't great is that we can see this many import attempts in a day or two. We either should not reattempt a failed import until at least 24 hours has passed, or disable the import after 5 days of failures rather than 5 failed attempts. A CVS server going down for a weekend should not disable Launchpad imports.
Related branches
lp:~mwhudson/launchpad/back-off-failing-imports-bug-413637
- Tim Penhey (community): Approve
-
Diff: 176 lines (+64/-24)3 files modifiedlib/lp/code/interfaces/codeimportjob.py (+12/-3)
lib/lp/code/model/codeimportjob.py (+27/-21)
lib/lp/code/model/tests/test_codeimportjob.py (+25/-0)
- Canonical Launchpad Engineering: Pending requested
-
Diff: 873 lines (+431/-102)13 files modifiedlib/canonical/buildd/debian/launchpad-buildd.init (+1/-1)
lib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+1/-1)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+94/-10)
lib/lp/buildmaster/tests/test_buildfarmjobbehavior.py (+80/-8)
lib/lp/code/interfaces/codeimportjob.py (+7/-3)
lib/lp/code/model/codeimportjob.py (+26/-21)
lib/lp/code/model/recipebuilder.py (+11/-2)
lib/lp/code/model/tests/test_codeimportjob.py (+25/-0)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+4/-3)
lib/lp/testing/factory.py (+87/-40)
lib/lp/translations/doc/translationtemplatesbuildbehavior.txt (+41/-12)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+17/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+37/-0)
Revision history for this message
| Tim Penhey (thumper) wrote Re: [Bug 413637] [NEW] imports disabled too rapidly | #1 |
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: code-import |
| tags: | added: trivial |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| Changed in launchpad-code: | |
| assignee: | nobody → Michael Hudson (mwhudson) |
| milestone: | none → 10.03 |
| status: | Triaged → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
On Sat, 15 Aug 2009 02:47:42 Stuart Bishop wrote:
> Public bug reported:
>
> Imports are automatically disabled after 5 failures, which is great.
> What isn't great is that we can see this many import attempts in a day
> or two. We either should not reattempt a failed import until at least 24
> hours has passed, or disable the import after 5 days of failures rather
> than 5 failed attempts. A CVS server going down for a weekend should not
> disable Launchpad imports.
>
> ** Affects: launchpad-code
> Importance: Undecided
> Status: New
We were considering an exponential backoff on failure, but this hasn't been
implemented yet.
status triaged
importance medium