Launchpad itself

Please expose a method to get all merge proposals that a person has been asked to review in the API

Bug #411357 reported by James Westby
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
James Westby
Launchpad itself 10.02

Bug Description

Hi,

lp.me.getMergeProposals() gets the merge proposals that I created.

I would like a method that gets all the merge proposals that I have been requested
to review. Having a parameter that controls whether that is directly or indirectly through
team memberships would be great.

That way I can query my review TODO list from the API.

Having to provide a list of projects is limiting and makes it harder to write
generic tools.

Thanks,

James

Related branches

lp:~james-w/launchpad/get-requested-reviews
Tim Penhey (community): Approve
Eleanor Berger (community): Needs Fixing
Diff: 186 lines (+79/-10)
6 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+6/-5)
lib/lp/code/interfaces/hasbranches.py (+31/-0)
lib/lp/code/model/hasbranches.py (+18/-1)
lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+17/-0)
lib/lp/registry/interfaces/person.py (+4/-2)
lib/lp/registry/model/person.py (+3/-2)
Diogo Matsubara (matsubara)
tags: added: api code-review
affects: launchpad → launchpad-code
Revision history for this message
Tim Penhey (thumper) wrote :

Yeah, I think this is a good idea. I'm going to be working in this type of area soonish anyway :)

Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Daniel Holbach (dholbach) wrote :

It'd be important for us to have it, since we'd like to create lists of all the source package branches that need reviewing to get them uploaded into Ubuntu. At the moment that'd be:

 * https://code.launchpad.net/~ubuntu-branches/+activereviews
 * https://code.launchpad.net/~ubuntu-main-sponsors/+activereviews
 * https://code.launchpad.net/~ubuntu-universe-sponsors/+activereviews

With Archive Reorganisation I expect there's going to be more quite soon.

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 411357] Re: Please expose a method to get all merge proposals that a person has been asked to review in the API

On Fri, 18 Dec 2009 12:47:47 -0000, Daniel Holbach <email address hidden> wrote:
> It'd be important for us to have it, since we'd like to create lists of
> all the source package branches that need reviewing to get them uploaded
> into Ubuntu. At the moment that'd be:
>
> * https://code.launchpad.net/~ubuntu-branches/+activereviews
> * https://code.launchpad.net/~ubuntu-main-sponsors/+activereviews
> * https://code.launchpad.net/~ubuntu-universe-sponsors/+activereviews
>
> With Archive Reorganisation I expect there's going to be more quite
> soon.

And with lp.distributions['ubuntu'].getMergeProposals() not implemented
(I assume to do with +activereviews not being there) the only choices
we have for getting this information is screen-scraping and pointing
to a list of +activereviews pages for each team.

Thanks,

James

Revision history for this message
Jonathan Lange (jml) wrote :

It's simply due to Distribution not inheriting from lp.code.model.hasbranches.HasMergeProposalsMixin, and to the external API interface having no support for adapters. If it had support for adapters, we wouldn't need to remember to expose it.

However, that's a separate (trivial!) bug.

Revision history for this message
James Westby (james-w) wrote :

Talking with Tim suggests that something like

  IPerson.getRequestedReviews(direct=True, pillar=None, status=...)

would be useful, where direct changes whether it includes those requested
from teams this IPerson is a member of, pillar allows you to filter by a pillar,
and status allows you to filter by the merge proposal statuses (Needs review
by default).

Thanks,

James

Revision history for this message
Daniel Holbach (dholbach) wrote :

This would incredibly useful for http://qa.ubuntu.com/reports/sponsoring/index.html which is sort of the "what can I review and upload" list.

Revision history for this message
James Westby (james-w) wrote :

https://code.edge.launchpad.net/~james-w/launchpad/get-requested-reviews/+merge/18592

Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → Fix Committed
assignee: nobody → James Westby (james-w)
milestone: none → 10.02
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.