tales linkify create broken links
Bug #404131 reported by
Curtis Hovey
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Ian Booth | ||
Bug Description
The lp:openssl was linkified by tales.FormattersAPI lpbranchurl rule in this question
https:/
The link is broken. It goes to the wrong vhost. The link will not work anyway since the project does not have focus of developement set (that is not the linkers) problem
There is a minor complication. The Ubuntu developers use lp:1234 to reference bugs. The URL rule should verify that all numbers are never linked to a branch.
Related branches
lp:~wallyworld/launchpad/tales-linkify-broken-links
- Tim Penhey (community): Approve
-
Diff: 376 lines (+218/-39)4 files modified.bzrignore (+2/-0)
lib/canonical/launchpad/browser/launchpad.py (+30/-10)
lib/canonical/launchpad/browser/tests/test_launchpad.py (+184/-27)
lib/lp/testing/factory.py (+2/-2)
Revision history for this message
| Jonathan Lange (jml) wrote | #1 |
| Changed in launchpad-code: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| tags: | added: trivial ui |
Revision history for this message
| Jonathan Lange (jml) wrote | #2 |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #3 |
Revision history for this message
| Tim Penhey (thumper) wrote | #4 |
| Changed in launchpad-code: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #5 |
| Changed in launchpad-code: | |
| milestone: | none → 10.10 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Only one part of this bug is actually a bug, imho: the link should only ever refer to the code vhost.
The URL rule already verifies that all numbers are never linked to a branch (there's a fix released bug about this). Also, if you look at your own bug comment, you'll see that lp:1234 links to the bug report.
There is no way we're going to check for the existence of the development focus. It would cause too many database queries. Note that the current behaviour of bug linking is to create a link to a bug regardless of its existence.