Launchpad itself

merge requests stay in list of requested code reviews even though they have been voted on

Bug #385255 reported by Jelmer Vernooij
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Tim Penhey
NULL Project
Invalid
Undecided
Unassigned

Bug Description

Even after I process a merge request and vote on it, it still stays in my list of requested code reviews. This makes it hard to use +requestedreviews as my todo list for code reviews I have to work do..

Revision history for this message
Jonathan Lange (jml) wrote :

I'm pretty sure the recent +activereviews page fixes this.

Changed in launchpad-code:
assignee: nobody → Jelmer Vernooij (jelmer)
status: New → Incomplete
Revision history for this message
Aaron Bentley (abentley) wrote :

Not if Jelmer meant "vote" and not "set its status".

Revision history for this message
Jonathan Lange (jml) wrote :

The +activereviews listing changes based on vote.

I guess it's existence doesn't make the +requestedreviews page any better though.

tags: added: code-review ui
Changed in launchpad-code:
importance: Undecided → Medium
status: Incomplete → Triaged
Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 385255] Re: merge requests stay in list of requested code reviews even though they have been voted on

On Wed, 24 Jun 2009 10:47:44 Jonathan Lange wrote:
> The +activereviews listing changes based on vote.
>
> I guess it's existence doesn't make the +requestedreviews page any
> better though.
>
> ** Tags added: code-review ui
>
> ** Changed in: launchpad-code
> Importance: Undecided => Medium
>
> ** Changed in: launchpad-code
> Status: Incomplete => Triaged

I'm pretty sure I've talked to Paul about removing the +requestedreviews page
now we have the +activereviews showing both requested and waiting on.

Revision history for this message
John A Meinel (jameinel) wrote :

Note that on the flip side it is really nice to have a "oh and this has been approved so I should land it".

As long as it is in a separate section, I prefer to see the both things that have and things that haven't been approved.

Revision history for this message
Jay Pipes (jaypipes) wrote :

Anybody know how I can remove this bug's link to the Drizzle project? I mistakenly attached it to Drizzle thinking I was setting a "this bug affects this project" kind of thing...

Revision history for this message
Tim Penhey (thumper) wrote :

On Thu, 23 Jul 2009 08:55:41 Jay Pipes wrote:
> Anybody know how I can remove this bug's link to the Drizzle project? I
> mistakenly attached it to Drizzle thinking I was setting a "this bug
> affects this project" kind of thing...

Apparently not. You can set it to invalid, but you can't currently remove the
task.

Revision history for this message
Jay Pipes (jaypipes) wrote :

Thanks Tim, did just that.

Changed in drizzle:
status: New → Invalid
Matthew Paul Thomas (mpt)
affects: drizzle → null
Tim Penhey (thumper)
Changed in launchpad-code:
assignee: Jelmer Vernooij (jelmer) → Tim Penhey (thumper)
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.