preview cutoff at 1.3 MB too small for images

I should say that this deficiency shows up in the "Import..." dialog when preview is enabled and a (say) .jpg file with 2.0 MB size is selected: we get "too large for preview" instead of a thumbnail image.

It may be a bit more complicated, but we could also use thumbnails , if available.

I made a patch against the last SVN trunk revision, I hope
it cleanly applies in BZR still.

I tried to match the style, feel free to fix if it hurts your eyes.

If I understand correctly, this patch completely removes the size limit is the image is valid.
I thought you just wanted to increase this limit?

@ Jazzy: Yep, I have zapped the limit for images in the patch. Why? Since I cannot come up with a good limit. If I say 10 MB, then next day some camera will create a 11 MB image :-(

It is very frustrating to see IMG10743.jpg .. IMG10821.jpg in a directory and not being able to preview them because of some arbitrary limit.

Of course I would agree to any limit (for morality reasons) that is beyond 20 MB :-)

I agree we should revise the limit up, with the overall progress in hardware it's inevitable. But we should not remove it - it is there for a reason.

Okay, here comes a revised patch, that imposes the old limit
on non-image docs and a new limit of somewhat over 10MB
for images. Can somebody apply this for release 0.48? THANKS!

I'm going to change the file size (also needs to be changed in filedialogimpl-win32.cpp).
Is the first test of your patch (if (fileLen > 0x150000L && !isValidImageFile(fileName) || fileLen > 0xA00000L)) really necessary?

Thanks, Jazzy!

I left in the 0x150000L limit for svg files etc., because I wanted a conservative patch. In another place the comment came up that previewing too big files does make the dialog feel sluggish. Imagine rendering a 9 MB .svg file in the preview dialog ;-)