0.47pre3-1.win32 crash when resizing "about Inkscape" dialog

confirmed with Inkscape 0.46+devel r22457 on OS X 10.5.8

console message:
**
ERROR:display/nr-filter-units.cpp:43:void Inkscape::Filters::FilterUnits::set_resolution(double, double): assertion failed: (x_res > 0)

This patch seems to fix it (at least here for me). I know it isn't ideal but the release is so near...
Can you please confirm it works for you? If so, please mark it for inclusion in 0.47

patch tested and fix confirmed with Inkscape 0.46+devel r22457 + patch on OS X 10.5.8

@Luca - on which platform did you test your patch: win32 or linux?

@~suv I'm almost always on linux (debian sid), this time too. My omonymous alter-ego too, so this won't fool you again ;)

Can someone please test the patch on win32 so we can bug the release warden to commit it?

the problem occurs in devel pre4-22465 under windows7 too.

more Information: It happens only if the height is under a certain value. Changing the width is working fine.

yes - to be expected, because the patch isn't in SVN yet ;-) Could you apply the patch attached to comment #2 and test?

@uwesch:
> under windows7
just curious - can you confirm the behavior described in bug #316894 (crash after 30 min of use)?

okay, sorry.

I applied the patch in my svn and tested it. Everything is working fine.

Thumbs up!

Thank you for testing the patch!

Is this platform specific then? I don't see the crash here on Linux. Does anyone see it on OSX?

bug was reported by a windows user, reproduced on osx and on linux (@Luca - you did see the crash too, on debian?)
patch was tested with linux (debian sid), osx (10.5.8) and win32 (windows7).

This makes me curious... what version of gtk are you all using? I'm on 2.18.2 here...

osx:
1) local SVN build uses 2.16.5
2) Michaels 0.47pre3 (crashes as well) I think uses 2.16.6

The newer builds by Michael will probably have 2.18.2 (was updated 8 days ago on MacPorts)
Unfortunately I can't update any dep libs at the moment - so no testing with gtk 2.18.2 here ;-(

If it is indeed an issue with gtk, I'm hesitant to commit the patch honestly.

You can resize the about-dialog so that the drawing area gets height=0 without crash? (I had been wondering if other window managers restrict the min vertical window size…)

Reproduced on Ubuntu 9.04, Inkscape revision 22476, and gtk 2.16.1-0ubuntu2.

~suv,

Nevermind... apparently I didn't take it all the way down. Yes I can reproduce too. I did ask Niko to take a look at the patch to see what he thinks (yes it's a simple patch, but he's our filters guru, and I want to avoid any potential unexpected side effects).

I looked at and tried the patch and it is all good. In general, I'm somewhat concerned about what happens if _filter_resolution returns near-zero width/height and why it returns zero or negative widths/heights in the first place. Nevertheless, these concerns don't make this patch any less useful.

Committed in 22517, Thanks Luca!