ENTER does not work anymore in Transform dialog

Bug #227949 reported by worms_x
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Confirmed
Medium
Unassigned
Declined for 0.46.x by Qantas94Heavy
Declined for 0.47.x by Qantas94Heavy
Declined for Old by Qantas94Heavy

Bug Description

In the 0.45.1 version of Inkscape, pressing <ENTER> after entering a value in the Transform dialogs validates and executes the transformation.

In 0.46 (as well as in the 0.46 dev builds), this functionality is lost, and it's really a pain to have to use the mouse / touchpad to click "apply".

Can the <ENTER> key be back?

Tags: ui
Alvin Penner (apenner)
Changed in inkscape:
status: New → Confirmed
Revision history for this message
Alvin Penner (apenner) wrote :

this is a problem of not having the focus on the right object
- if you apply a transform and then immediately hit Enter, then nothing happens
- if you click on the Apply button once, and then repeatedly hit Enter, then every hit on the Enter key will be recognized
- so the focus needs to be given to the Apply button by default, and should not require a mouse click

Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

No, it's not really a matter of not having focus.

Rather it is a need of having the Apply button be the "default button" The entry areas, etc. need to keep focus so that they will be usable.

(this is important, as we do have some places that pass on focus, but this is not one that should)

Luca Bruno (lucab)
Changed in inkscape:
importance: Undecided → Low
Changed in inkscape:
importance: Low → High
Revision history for this message
John Cliff (johncliff) wrote :

We have the calls on the spinboxes to pass enter to the default control, we dont seem to have anythign to set the default tho, and I cant work out how to set it.

Revision history for this message
Diederik van Lierop (mail-diedenrezi) wrote :

Originally, the desired behaviour was implemented by Bulia In rev. #13397. It was again removed in rev. #16541 when Gustav implemented the floating panels (which is a good thing!). In that transition though, the reference to the dialog got lost, which was needed to use the set_default() call. Apparently we're using a new version of the GTK libs too, as the original set_default is now called gtk_window_set_default if I'm correct.

So I think we should add a call to gtk_window_set_default() on line 162 of ui/dialog/transformation.cpp, but that requires a reference to a GTK_WINDOW. Now where do we get that reference from? This is probably exactly what John stuck too :-(

http://library.gnome.org/devel/gtk/stable/GtkWindow.html#gtk-window-set-default

tags: added: ui
removed: accessibility
jazzynico (jazzynico)
Changed in inkscape:
importance: High → Medium
Revision history for this message
Wong Cho Ching (chwong249664) wrote :

My proposed fix to this bug.
It looks stupid. But I am unable to find a better solution than this one. :(

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.