Inkscape

Inkscape GTK3 fails to build with GTKMM_DISABLE_DEPRECATED defined

Bug #1088264 reported by Alex Valavanis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Triaged
Medium
Unassigned

Bug Description

The experimental GTK+ 3 build fails if GTKMM_DISABLE_DEPRECATED is defined using:

make -k CPPFLAGS+="-DGTKMM_DISABLE_DEPRECATED"

The offending symbols will all be removed from future versions of Gtkmm so we need to ensure that we can build cleanly with this flag enabled.

See also Bug #1016020 <Inkscape GTK3 build fails with -Werror=deprecated-declarations>

See original description
Alex Valavanis (valavanisalex)
Changed in inkscape:
status: New → Triaged
importance: Undecided → Medium
Alex Valavanis (valavanisalex)
tags: added: gtk3
removed: gtk3-regression
Alex Valavanis (valavanisalex)
description: updated
Revision history for this message
Alex Valavanis (valavanisalex) wrote :
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Updated build-log attached

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Nearly done. Just need to migrate Gtk::Main to Gtk::Application

Revision history for this message
su_v (suv-lp) wrote :

> Nearly done. Just need to migrate Gtk::Main to Gtk::Application

With the latest round of changes (r12199), the 'Fill & Stroke' dialog no longer renders the content of the tabs ('Fill', 'Stroke paint', 'Stroke style') - reproduced with GTK+/X11 3.4.4 and GTK+/Quartz 3.6.2 on OS X 10.7 (GTK2 builds are ok).

Console messages:

(inkscape:97571): Gtk-CRITICAL **: void gtk_grid_attach(GtkGrid *, GtkWidget *, gint, gint, gint, gint): assertion `width > 0' failed

(inkscape:97571): Gtk-CRITICAL **: void gtk_grid_attach(GtkGrid *, GtkWidget *, gint, gint, gint, gint): assertion `width > 0' failed

(inkscape:97571): Gtk-CRITICAL **: void gtk_grid_attach(GtkGrid *, GtkWidget *, gint, gint, gint, gint): assertion `width > 0' failed

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Oops... easy fix. The order of the parameters of the attach function just need to be switched round from (left, right, top, bottom) to (left, top, width, height) [1]

[1] http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12196#src/ui/dialog/fill-and-stroke.cpp

Revision history for this message
su_v (suv-lp) wrote :

> The order of the parameters of the attach function just need to be
> switched round from (left, right, top, bottom) to (left, top, width, height)

'Fill and Stroke' is ok if recompiled with attached patch (please verify).

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

The code looks good to me... I can test it later on, but I'm pretty sure it's OK. Feel free to apply :-)

Revision history for this message
su_v (suv-lp) wrote :

Fix committed in r12200.

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Oops again! Should have been a conditional build: see bug #1155356

jazzynico (jazzynico)
tags: added: code-design
Revision history for this message
Tavmjong Bah (tavmjong-free) wrote :

Status?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.