Remove "Open with" and quotation marks from entries in "Open with" sub-menu

The file context menu as it stands.

The text to be removed is highlighted in red.

Here is a mockup of the proposed changes.

Should the tooltip still include the quotation marks? Current tooltip is "Use \"%s\" to open the selected item".

marcus you assigned this bug to yourself, do that mean you will work on the required code changes?

Yes, that was the plan. I've already made the fix local. Will do some testing and trying in karmic and then attach the patch later. Should I post it here or upstream?

Look at these two screenshots, the first looks OK to me (also includes the appicons from bug #387796) but the second seams a little strange - it's not totally obvious that you'll open the file with the applications in the list.

would be nice to send the change upstream and there

Forgot to remove the quotes on the default application in the first to screenshots. Here's an updated one.

Here's a combined patch for this bug and bug #387796, applied and you get a menu like the screenshot above.

@Marcus Carlson:
 Screenshot showing the applications in the main menu , doesnt make sense without the 'Open with' ,
A better way would be to use the 'Open with' when only 2 apps are listed, so that the main window has the Open with , while the submenu doesnt.

mac_v, I agree. I'll see what I can do.

Great work. I agree with you guys -- we are only removing "Open with" from items in the sub-menu; top-level "Open with X" entries retain "Open with" but lose quotation marks.

OK, how about it now?

Updated patch (also includes the icons). Needs review as I'm not sure if it complies to coding standards and so on...

If everything goes as planned, I'll have a patched nautilus in my newly created PPA so you can all try this and not just look at the screenshots. :-)
https://launchpad.net/~0-launchpad-mejlamej-nu/+archive/ppa/+sourcepub/662969/+listing-archive-extra

Wait for the ~a2 version... (if it comes up :-) )

@Marcus Carlson :
Looks good :)
While you are at it , could you take a look at this, its is somewhat a similar papercut >
https://bugs.launchpad.net/hundredpapercuts/+bug/392423
Its about adding an icon for the unmount menu item.

@David Siegel: Your thoughts on the above papercut?

@Marcus Carlson : Ah ... found that the "Open with Other application" is the submenu also doesnt need the "Open with"
In the submenu, It could just be "Other Application"

mac_v, sure. Will hack on it tonight.

Just "Other application" in submenu.

Application icons (bug #387796) and open with changes patch.
Anyone want a package as well to try it out?

Looks Great :)

This is looking much better, great job! Personally I liked keeping the "Open with" for the "Open with Other Application", it seems to make it clearer to me somehow, and differentiates it a bit. Also, that capitalization seems a bit off, why not "Open with other application" instead of "Open with Other Application"?

Are we happy with the changes or shall we do as Michael suggest?

I like the idea of this bug and what Marcus has done to fix the problem (implementing David's suggestions), but why are we getting rid of the "Open with..." submenu when only 2 programs are available? That's changing what the user expects to see from one file to the next. To me, the "Open with..." submenu should be there always, or never and not be contextually dependent.

That's like changing the icon of the close button in Metacity from "X" to "O" depending if it's maximized or not. The user should expect to see the same result every time.

Thus, I would like to see http://launchpadlibrarian.net/28606444/noquotes.png implemented.

Brett, I've noticed this and agree completely, but it's a different
issue (and maybe a paper cut). Will you please file a bug about it?

On Jul 6, 2009, at 9:02 PM, Brett Alton <email address hidden>
wrote:

> I like the idea of this bug and what Marcus has done to fix the
> problem
> (implementing David's suggestions), but why are we getting rid of the
> "Open with..." submenu when only 2 programs are available? That's
> changing what the user expects to see from one file to the next. To
> me,
> the "Open with..." submenu should be there always, or never and not be
> contextually dependent.
>
> That's like changing the icon of the close button in Metacity from "X"
> to "O" depending if it's maximized or not. The user should expect to
> see
> the same result every time.
>
> Thus, I would like to see
> http://launchpadlibrarian.net/28606444/noquotes.png implemented.
>
> --
> Remove "Open with" and quotation marks from entries in "Open with"
> sub-menu
> https://bugs.launchpad.net/bugs/394356
> You received this bug notification because you are a direct subscriber
> of the bug.

@Marcus Carlson:
The sub menu without "Open with" makes it more consistent...

But wait for the David Siegel to make the final call.

@David Siegel,
the "Open with" submenu creates only when more than 2 alternative apps are present , this is the default behavior, it would be unnecessary for a submenu for 1/2 apps.

For example: if a user wants to view a picture he opens with image viewer. Usually firefox is also listed in the open with menu for png/jpg files.
But when he has to edit , it would be better to have it in the main menu rather than the submenu creates unnecessary extra navigation.

So the default behavior of showing 2 apps is ideal.

Marcus, please leave "Open with" out of the "Open with" sub-menu completely -- even for the "Other Application..." entry.

Again, let's leave the discussion of whether or when to show the sub-menu for another bug.

On Tue, Jul 7, 2009 at 3:56 AM, David Siegel<email address hidden> wrote:
> Marcus, please leave "Open with" out of the "Open with" sub-menu
> completely -- even for the "Other Application..." entry.

Is it only me that finds capitalizing the "A" in application
unattractive and improper? It seems like "Other application" is more
polished and parsable. I just wanted to make sure since I didn't see
it specifically addressed but if the design consensus is that it
should be capitalized, that's fine, I just want to make sure it wasn't
overlooked.

@Michael Rooney"
"Application" with "A" is correct, since we are treating is as a proper noun.
Maybe the "Other" could be "other" but that wouldnt look good. ;)

the bug has been fixed upstream now

@Michael and mac_v
What about open with "Another application..."or "Open with another application"?

@Lightbreeze :
"Another" would mean dual opening, Open with an another[second] application along with the first.

the issue is fixed in karmic