Entering WEP/WPA key/passphrase requires tabbing/clicking

I can confirm this. Also it is valid and comes under OHPC.

Sam, could you explain what you mean by:

"if [the] network key is a passphrase, then an extra shift-tab would be required"?

I assume you're talking about a WEP passphrase too, correct?

sorry if that was not clear.

in current NM when the dialog come up the 'Wireless security' menu (which has a drop down menu of 'WEP 40/128-bit key', 'WEP 128-bit passphrase', 'LEAP', 'Dynamic WEP') is focused.

for people who need to select an option other than 'WEP 40/128-bit key', and who want to use the keyboard, this is a good way to start. for people who will activate the drop down with the mouse, the initial focus does not matter. users who want to use a 'WEP 40/128-bit key', will have to tab down to the key input before they can type.

i suggest that that the initial focus be moved to the key entry. because i think using a key is more common that a passphrase (just based on my experience). also i think the drop down menu is most likely to be activated with the mouse.

people who navigate menus and everything by keyboard, and use something other 'WEP 40/128-bit key', will be slowed down a bit because the initial focus would not be optimal.

+1

Attached is a patch that focuses the key / passphrase fields when connecting to wireless networks.

There are some caveats though: the EAP and dynamic WEP dialogs don't focus yet, and focus is not set when creating a connection manually.

Patch also submitted upstream.

from what i understand the patch is incomplete. also there are more ideas on wep dialog in https://blueprints.edge.launchpad.net/ubuntu/+spec/desktop-karmic-network-ui for this cycle. Would you want to work on that too?

assigning to tony who planned to work on the wep dialog.

Attached is a new patch that takes dynamic WEP and EAP in account also. I wasn't able to test it because i don't have such an access point, though.

The previous patch already addressed WEP and WPA dialogs, which I think are most common.

Alexander: I've got a lot of work this summer and I'm not sure I can lean the intricacies of the network manager in that short a time, I'll have to wait and see..

I applied and tested the patch this afternoon and found that there's still some work to be done.

WEP 40/128 -- no focus, Enter key doesn't work

WPA-PSK -- no focus, Enter key works

I looks like the code only explicitly sets the new default_field focus in the function ws_802_1x_auth_combo_changed (). As I don't have to much experience with Gtk code, I could be missing something obvious here...

As for the other methods, I'll probably have to tweak the code in order to cause the other dialogs to display, as I don't have an access point setup that I can configure for the remaining security types...

So it looks like the Enter key behavior is controlled by the Gtk "activates_default" property. In applet.glade, it's set to "TRUE" for the wpa_psk_entry, and "FALSE" for wep_key_entry.

Oops. Somehow my patch didn't contain the src/wireless-dialog.c changes.

I've made a new patch that contains them and the focusing works.
I also fixed the "activates_default" property for wep dialogs.

Tony: can you test this new patch? Sorry for the other one, not sure how that happened.

Sure will do. Thanks for the quick turnaround!

OK, just tested the WEP 40/128 case, and it works perfect ( ie. entry field in focus & Enter works ).

I'll test WPA-PSK and the other cases first thing tomorrow and if all is OK, will pull together a bzr branch and submit a merge request.

Thanks!

Wonderful work, guys! I am moving the paper cut milestone back a week due to GUADEC. News of this fix will make many users happy :)

So I've tested WEP 40/128 and WPA Personal using a live access point, and both work as expected.

For LEAP, I ended up hacking the code so that LEAP is the only method added to the security combo. It works as expected, although I had to modify applet.glade again to make the LEAP password trigger the default action as we did for WEP. I expect I'll need to do this for most of the remaining eap-* methods that have password fields.

I planned to use the same approach to test all of the other methods.

I immediately ran into a problem with Dynamic WEP(802.1x) / TLS. The dialog displays and the security combo still has focus.

The problem is that although the focus is set using the the eap_default_field in the function ws_802_1x_auth_combo_changed(), during initialization of the combo by security_combo_init(), internal_init() then resets the focus to the security combo itself. The later revalidate() call in this case does nothing because sec->default_field is NULL for dynamic WEP and WPA Enterprise.

There's a slight possibility that my test patch ( see attached ) caused the problem, however I don't think that's the case.

I'm working on a fix...

I'm attaching the final version of the patch.

The changes include:

 - for WEP/WPA key/passphrase dialogs, focus is set to key/passphrase; for LEAP, it's set to
   username. If a user changes the security combo to another type, the focus is reset too.

 - for all dialogs ( key required, connect to other, create network ), the key, passphrase,
   or password entry field now triggers the default action ( 'Connect' ), on an Enter keystroke

 - Dynamic WEP / WPA Enterprise versions of the dialog don't auto-focus; this will be treated as
   a separate bug

 - WEP/WPA/LEAP testing can be done with a single AP, no hard-coding is necessary unless you don't
   have access to an AP which you have admin rights for ( ie. to switch between WEP & WPA )

This bug was fixed in the package network-manager-applet - 0.7.1.git.3.0461fff8-0ubuntu2

---------------
network-manager-applet (0.7.1.git.3.0461fff8-0ubuntu2) karmic; urgency=low

  [ Tony Espy <email address hidden> ]
  * update build-depends for networkmanager bits to >= 0.7.1.git.5
    - update control
  * fix LP: #390362 - Entering WPA/WEP key/passprases requires tabbing/clicking
    - add patches/lp390362_dialog_key_passphrase_focus.patch
    - update patches/series

  [ Alexander Sack <email address hidden> ]
  * upstream snapshot - 2009-07-29 18:20:10 (GMT)
    + commit 0461fff8039ce612fb5a50ce760b782f62457d59
  * drop mbca patch because upstream ships its own wizard now
    - delete patches/add_libmbca_support.patch
    - update patches/series
  * drop libmbca-dev from build-depends as nm applet builds its own wizard
    now; in turn depend binary package on mobile-broadband-provider-info >= 20090622
    - update controld
  * adjust patches to changed upstream code base
    - update patches/lp341940_use_ellipsized_menu_entries.patch
    - update patches/lp337960_dxteam_notification_icon_names.diff
    - update patches/lp341684_device_sensitive_disconnect_notify.patch
  * keep gtk < 2.14 supported for hardy
    - add patches/gtk210_support.patch
    - update patches/series
  * drop libmbca0 from Recommends
    - update control

 -- Tony Espy <email address hidden> Tue, 04 Aug 2009 10:13:53 +0100

Since this has landed in Karmic I'll mark it Fix Released to match the corresponding task.