Display application icons for "Open With" entries in the context-menu

Bug #387796 reported by Loïc Alejandro
32
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Nautilus
Fix Released
Medium
One Hundred Papercuts
Fix Released
Undecided
Unassigned
nautilus (Ubuntu)
Fix Released
Wishlist
Ubuntu Desktop Bugs

Bug Description

When you right click on a file and choose "open with ...", you get a list of softwares. I was thinking it would be nice to see the icons of the proposed softwares with their names.

##########

Design suggestion:
  * Show application icons in the "Open with" sub-menu, and in the context menu when there is no sub-menu.
  * For applications without icons, use the generic application icon, application-x-executable.

Tags: menu-icons
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

You mean like this? Here is my "Open with..." dialog in Jaunty.

Revision history for this message
Loïc Alejandro (loic-alejandro) wrote :

No, I am talking about this one

Changed in hundredpapercuts:
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report. The issue is an upstream one and it would be nice if somebody having it could send the bug the to the people writting the software (https://wiki.ubuntu.com/Bugs/Upstream/GNOME)

Changed in nautilus (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Wishlist
Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in nautilus (Ubuntu):
status: New → Triaged
Changed in nautilus:
importance: Undecided → Unknown
status: New → Unknown
Changed in hundredpapercuts:
milestone: none → round-2
Changed in nautilus:
status: Unknown → New
Revision history for this message
Sebastien Bacher (seb128) wrote :

note that the design team was trying to limit icons use in menu because they think that a menu for each item overload the menu, would it make sense to add an icon for each application there?

Revision history for this message
Lorenzo (lorenzo-delledonne) wrote :

Yes, that's a proper observation. BUT, we are talking about a sub-menu containing only a list of applications, and applications are better recognizable by using their own icons.

Revision history for this message
Sebastien Bacher (seb128) wrote :

how much can you guess from a tiny icon though

Revision history for this message
A. Walton (awalton) wrote :

Just for the record, this is a Good example of something that could be considered a paper cut (it's a small fix with a design problem), but I tend to ask the same question as Sebastien has above. And that menu is starting to become icon-noisy as it is.

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

First, C is not my native language (Java guy) and I've almost never written anything in C. But Fixing small bugs like this seems like a good start to learn. So here's my one-liner to add icons to the Open with list.
I would like some comments whether I need to free the icon and if getting icons should be done async.

My comment on this bug; if we should set icons for the applications in the "Open with" list I think an application icon should also be set for the default option instead of the standard icon.

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

Screenshot showing icons in the Open with list using the patch.

@Sebastien Bacher - I think you could guess a lot from the icons :-)

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

Sorry, I should have read upstream first. Seems like this is already fixed in master. My bad.
Can we mark this as fix committed?

Revision history for this message
Sebastien Bacher (seb128) wrote :

upstream changed to add the icon only for the default choices, it would still be nice to get comments from the designers on whether having an icon for each entry makes sense since some argue against using too many icons

Revision history for this message
Sebastien Bacher (seb128) wrote :

could you also add your change upstream for review?

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

I think I need to update the patch but when done I could post it upstream. But comments from designers would be good, like should we default to GTK_STOCK_OPEN for applications without icon?

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Marcus, I suggest using no icon for applications without icons and using icons for both default choices and entries in the Open with... submenu.

Changed in hundredpapercuts:
assignee: nobody → Marcus Carlson (0-launchpad-mejlamej-nu)
status: Confirmed → In Progress
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Design suggestion:
  * Show application icons in the "Open with" sub-menu.
  * For applications without icons, use the "generic application icon" (I am looking for its name).

Revision history for this message
Sebastien Bacher (seb128) wrote :

do you suggest adding the icons only in the sub-menu or also in the context menus for each option when there is no submenu?

description: updated
description: updated
Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

Added a screenshot in bug #394356 where the icon is changed to application-x-executable.
See http://launchpadlibrarian.net/28605098/appicons_exec.png
Better?

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

That's wonderful, Marcus!

Changed in hundredpapercuts:
status: In Progress → Fix Committed
summary: - Display icons in the "open with ..." list
+ Display application icons for "Open With" entries in the context-menu
Changed in nautilus:
status: New → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

the issue is fixed in karmic now

Changed in nautilus (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Vish (vish) wrote :

https://bugs.launchpad.net/ubuntu/+source/libgnome/+bug/407621

Now gnome has decided to remove all icons from context menus...

Now nothing has icons ! [no icons in context menus, drop down menus or dialogue windows!]

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

I'm working on updating the patch to display icons for the applications as that should be valid according to the new "design guides" [1].

Also icons from buttons has also removed (OT).

[1] Reading the http://bugzilla.gnome.org/show_bug.cgi?id=557469 I get the feeling that files and applications should have an icon in menus.

Revision history for this message
Sebastien Bacher (seb128) wrote :

> "Now nothing has icons ! [no icons in context menus, drop down menus or dialogue windows!]"

there is no need to comment on this closed bug about that new change

Revision history for this message
Vish (vish) wrote :

> the issue is fixed in karmic now

when an bug is marked as fixed but is not , IMO ,this is misleading, there is a need for a comment.

it either needs to be marked as "wont fix", or "wishlist" ,Kindly update the bug status.

Revision history for this message
Kenneth Wimer (kwwii) wrote :

Well, a fix was commited and then upstream changed the playing field and the fix is purposely not needed. I would not say it is a "won't fix" as it was already fixed in the context of the original bug. Sounds like the issue someone would want to report as a bug was the design decision to remove the icons, naturally that is a wishlist bug and probably won't be changed, as it was a well-discussed issue but that is another matter.

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

Here's a quick patch to enable the application icons. Haven't got time to do much testing but it should be working.
Send it upstream?

Changed in hundredpapercuts:
status: Fix Committed → Fix Released
Revision history for this message
Vish (vish) wrote :

This is not fixed, the default is to show only minimal icons in menus and Marcus' new patch [comment #29 ] needs to be applied.

Changed in hundredpapercuts:
status: Fix Released → Triaged
Revision history for this message
Vish (vish) wrote :

Changing the status , after discussion in irc.

The apps are considered to as objects and need to have icons even with the default settings.

Changed in nautilus (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Vish (vish) wrote :

Changing the status , after discussion in irc.

The apps are considered as objects and need to have icons even with the default settings.

Revision history for this message
Marcus Carlson (0-launchpad-mejlamej-nu) wrote :

This should be fixed and committed in http://bugzilla.gnome.org/show_bug.cgi?id=590647

Vish (vish)
Changed in hundredpapercuts:
assignee: Marcus Carlson (0-launchpad-mejlamej-nu) → nobody
status: Triaged → Fix Committed
Changed in nautilus (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nautilus - 1:2.27.91-0ubuntu1

---------------
nautilus (1:2.27.91-0ubuntu1) karmic; urgency=low

  * New upstream release: (LP: #418405)
    - Migrate old-style nautilus metadata to gvfs metadata
    - Fix viewing of very small image files
    - Respect disable_command_line option
    - Reverse mouse button used for back/forward to same as firefox
    - Always show menu icons for menu items representing files (LP: #387796) (LP: #408384)
    - Inhibit suspend during file operations (LP: #49258)
    - Cancel audio preview when deleting the previewed file (LP: #36196)
  * debian/patches/01_lpi.patch:
  * debian/patches/02_autoconf.patch:
  * debian/patches/18_signal_curtain.patch:
  * debian/patches/90_relibtoolize.patch:
  * debian/patches/99_ltmain_as-needed.patch:
    - Refreshed

 -- Robert Ancell <email address hidden> Tue, 25 Aug 2009 13:15:20 +1000

Changed in nautilus (Ubuntu):
status: Triaged → Fix Released
Andrew (and471)
Changed in hundredpapercuts:
status: Fix Committed → Fix Released
Revision history for this message
Vish (vish) wrote :

This seems to have not been fixed properly.
The first option [the default choice which opens the file]in the context menu , still does not show the icon, but that would be a separate bug , Kindly file a separate bug for the issue. Thanks!

Changed in nautilus:
importance: Unknown → Wishlist
Mathew Hodson (mhodson)
Changed in nautilus:
importance: Wishlist → Undecided
status: Fix Released → New
importance: Undecided → Unknown
status: New → Unknown
Mathew Hodson (mhodson)
tags: added: menu-icons
Changed in nautilus:
importance: Unknown → Medium
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.