One Hundred Papercuts

"Hardware Drivers" displays empty error dialog when not connected to the network

Bug #386375 reported by mrosati on 2009-06-12

This bug affects 3 people

	Status	Importance	Assigned to
Jockey	Fix Released	Undecided	Unassigned
One Hundred Papercuts	Fix Released	Undecided	Unassigned
jockey (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

when driver installer tries to download a driver, it gives an insignificant error and stops the installation. would be much better if the error dialog could inform about the nature of error itself.

Tags:

Related branches

lp:~and471/jockey/fix-386375

Merged into lp:jockey

Registry Administrators: Pending requested 2009-09-17

lp:jockey

lp:~ubuntu-core-dev/jockey/ubuntu

lp:ubuntu/karmic/jockey

Revision history for this message

mrosati (rosati-matteo) wrote on 2009-06-12:

driver-installer-error.png Edit (83.8 KiB, image/png)

mrosati (rosati-matteo) on 2009-06-12

tags:

added: hundredpapercuts

Revision history for this message

wisd0m (wisd0m) wrote on 2009-06-15:

This needs to be fixed asap. I have had this happen many times and wonder how a new user might deal with it.

ShawnJGoff (shawnjgoff) on 2009-06-18

Changed in hundredpapercuts:
status:	New → Confirmed

David Siegel (djsiegel-deactivatedaccount) on 2009-06-22

Changed in hundredpapercuts:
milestone:	none → round-6

Revision history for this message

Jamie Strandboge (jdstrand) wrote on 2009-07-01:

Just encountered this today. The error box simply says 'Error' with no other information.

Changed in jockey (Ubuntu):
status:	New → Confirmed

David Siegel (djsiegel-deactivatedaccount) on 2009-08-11

summary:

- driver installer gives insignificant error when not connected to the
+ "Hardware Drivers" displays empty error dialog when not connected to the
network

Revision history for this message

Kevin Hausmann (salema) wrote on 2009-08-14:

I tried to look into this one and it seems like it originates from jockey/ui.py line 622:

self.error_message('', str(e).splitlines()[-1])

This is supposed to catch a generic SystemError and should probably read something like

self.error_message(self.string_error, str(e))

I am not much of a python programmer, but this should be easy to fix if you know what you are doing. Obviously it would be even better to present a more specific error message depending on the type of exception.

Andrew (and471) on 2009-08-26

Changed in jockey:
status:	New → Confirmed

Revision history for this message

Andrew (and471) wrote on 2009-08-26:

jockey.patch Edit (986 bytes, text/plain)

Attached is a patch for the jockey trunk branch

I fixed the empty error dialog and made the string more concise by using split('\n') instead of splitlines()

Also in the patch is a change for the jockey-gtk.ui file, it makes the progress dialog not show the text 0% (making it appear as though it was doing nothing

Can this please be applied to the jockey trunk

Changed in hundredpapercuts:
status:	Confirmed → In Progress
Changed in jockey:
status:	Confirmed → In Progress

Revision history for this message

Andrew (and471) wrote on 2009-09-05:

Added branch where problem is fixed, proposed for merge

Revision history for this message

Martin Pitt (pitti) wrote on 2009-09-17:

Current branch causes regressions, see merge proposal.

Changed in jockey:
status:	In Progress → Incomplete

Revision history for this message

Andrew (and471) wrote on 2009-09-17:

Okay, fixed my branch, ready for merge

Changed in jockey:
status:	Incomplete → In Progress

Revision history for this message

Martin Pitt (pitti) wrote on 2009-09-21:

Merged, thanks! (trunk r575)

Changed in jockey:
status:	In Progress → Fix Released
Changed in jockey (Ubuntu):
status:	Confirmed → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-09-21:

#10

This bug was fixed in the package jockey - 0.5.4-0ubuntu1

---------------
jockey (0.5.4-0ubuntu1) karmic; urgency=low

  * New upstream bug fix release:
    - Update tests for openprinting.org changes; LaserJet 3020 does not exist
      any more, replace with DesignJet 3050CP.
    - Handler: Reload module blacklist after installing a driver package,
      since it might ship blacklists.
    - setup.py: Fix DistUtilsExtra version check. (LP: #428337)
    - jockey-gtk: Check for having $DISPLAY at startup to avoid crashes.
      (LP: #204134)
  * ui.py: Fix error message parsing, thanks to rugby471! (LP: #386375)
  * Add data/handlers/dvb_usb_firmware.py: Handler for DVB USB cards which
    need to have the linux-firmware-nonfree package installed. (LP: #223212)