Default folders inside Home Folder (e.g. Documents, Music) should have special icons/emblems

Bug #126103 reported by Nicolò Chieffo
60
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Humanity
Fix Released
Undecided
Danielle Foré
One Hundred Papercuts
Fix Released
Medium
Kenneth Wimer
human-icon-theme (Ubuntu)
Fix Released
Undecided
Unassigned
xdg-user-dirs (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: nautilus

nautilus 2.19.4-0ubuntu2

now that xdg-user-dirs are available, nautilus should attach the right icon to them! And the icon should be also visible in the Places panel

Related branches

Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

Thank you for your bug report. I'm marking this as triaged, it would really be nice to have icons available to notice the differents folders easily.

Changed in xdg-user-dirs:
assignee: nobody → ubuntu-art
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Sebastien Bacher (seb128) wrote :

Not an artwork bug, the code doesn't add emblems at the moment

Changed in xdg-user-dirs:
assignee: ubuntu-art → nobody
importance: Medium → Wishlist
Revision history for this message
Ralf Nieuwenhuijsen (ralf-nieuwenhuijsen) wrote :

Related bug:
https://bugs.launchpad.net/ubuntu/+source/gnome-panel/+bug/129031

We can still give them icons by hand, but unfortunately, the places menu ignores those icons!

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

This is a patch to GIO, which selects some icons (missing from the icon theme of course new icons should be designed).
The patch to GIO makes nautilus pick up the correct icon.

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

This debdiff adds the required support. Now GIO supports emblemed icons, so no new icon must be designed!!!
Before applying this debdiff we need a patch to nautilus too.
Which is here:
https://bugs.launchpad.net/bugs/328743

Se you soon

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

Upstream wants to use separate icons (no emblems) so I asked to the icon naming spec guru, and he told that the icon names should be "folder-foo"

So this is the new patch.
Anyway upstream seems really not so interested on giving different icons for xdg directories...
Is canonical interested?

Nicolò Chieffo (yelo3)
tags: added: hundredpapercuts
Revision history for this message
Nicolò Chieffo (yelo3) wrote :

To hundred paper cuts:
I know this could be considered as a feature, but this patch works, and has no problems. the only part to do is to dray icons. I've requested them also upstream to gnome-icon-theme.
Also my request was forwarded to the breathe icon theme from the ubuntu community.

tags: removed: hundredpapercuts
Revision history for this message
Mat Tomaszewski (mat.t.) wrote :

This is a bigger artwork issue, not really a papercut

Changed in hundredpapercuts:
status: New → Invalid
Revision history for this message
Nicolò Chieffo (yelo3) wrote :

this can be considered a papercut in my opinion, since waiting for someone (not you papercutters) to release new icons, the following can be used:
Documents -> document.svg / emblem-documents.svg
Music -> sound.svg / emblem-sound.svg
Pictures -> image.svg / emblem-pictures.svg
Videos -> video.svg / emblem-multimedia.svg
Downloads -> www.svg / emblem-web.svg
Templates -> emblem-new / emblem-new.svg
Public -> folder.svg / emblem-shared.svg

And this is something that users will like.
If you still think it's not a good idea, close again and sorry.

Changed in hundredpapercuts:
status: Invalid → Incomplete
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

We may want to reconsider this as a paper cut, albeit a bit of a larger one. Let's leave it New in hundredpapercuts for now.

Changed in hundredpapercuts:
status: Incomplete → New
Revision history for this message
Nicolò Chieffo (yelo3) wrote :

Patch updated to apply on glib unstable

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

Papercut patch (screenshot soon)

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

It doesn't look bad, does it?
I need to edit the patch a bit to have fallback icons.

Revision history for this message
Vadim Peretokin (vperetokin) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

Not sure if using nautilus emblems (as it looks like) as icons is a great
idea.

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

Ok I will do other proposals. Would you prefer a folder with emblems?

Revision history for this message
Vadim Peretokin (vperetokin) wrote :

I would say that is best, yes.

Because a) that's how emblems are designed to use, b) they aren't meant to
be full-scale icons, so won't fit in with the other iconsets so much

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

I don't like emblems, because if the icon is small they won't be shown
(gnome panel for instance)
upstream doesn't want emblems either.
for isntance see the desktop icon and the home icon, thet used to have
emblems, but now they were redesigned completely.

I can't find a way to set a fallback icon if the icon is not found.
Any suggestion?
g_themed_icon_new () always returns something so I can't understand if
the icon is the one I've chosen or the "new-file" standard one.

Revision history for this message
Vadim Peretokin (vperetokin) wrote :

No afraid I've never implemented icons like that, was just looking into it a
few days ago but then the need for it dropped. I'd say ask in #gtk

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: should apply icons to xdg-user-dirs

Do you prefer this?

Revision history for this message
Yann Dìnendal (yannbreliere) wrote :

No, they should look like folders, not like any other 'object'. The only good way to do this, is to do new icons like the folder-home icon. It will take more time, but I don't think we are in a hurry to change these icons...

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

I'm not in a hurry. But if you don't have time, can you point me to a
simple guide on how to draw svg icons?
If it's not too hard I can try

Revision history for this message
Vadim Peretokin (vperetokin) wrote :

Download inkscape, open up an icon of the folder in it. Then open up one of
these icons, copy, drag it over (or import or open, don't remember which),
do a bit of alignment and resizing, and you should be good to go :)

Revision history for this message
Sebastien Bacher (seb128) wrote : Re: should apply icons to xdg-user-dirs

having folders with those icons looks weird, emblems are suppoed to be used on the side of an icon not to replace it

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

Anyway, upstream doesn't want emblems, so they replaced home and
desktop with full icons.
I agree with them, especially because it's not possible to see an
emblem in a 16x16 icon (for instance the panel or gtk file chooser)

I won't paste emblems inside the folder icon, I will try to propose
something better, if I will be able.
If you don't like it just tell me and I will try to improve the design

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: should apply icons to xdg-user-dirs
Revision history for this message
Nicolò Chieffo (yelo3) wrote :

This patch is using emblems. No additional work is required. This could be the final papercut patch.

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

screenshot with emblems. do you like it?
Note I've emblemed also the desktop (and home), to have a more coherent design.
If you prefer I can keep it as the normal icon

Revision history for this message
Vadim Peretokin (vperetokin) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

I like it.

Revision history for this message
Fred (eldmannen+launchpad) wrote : Re: should apply icons to xdg-user-dirs

Looks promising.

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

Note I didn't use emblem-foo, I preferred other icons (the most taken
from mimetypes) because they have more colors: emblems are just white
and orange. Do you want to see a screenshot with classic emblems?

I'm not so sure of the Public icon... comments?

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: should apply icons to xdg-user-dirs

Currently there are 3 missing emblems from the standard icon naming spec :
- music (or sound)
- video (or multimedia)
- new

I don't know if it's a good idea to use standard emblems, unless someone will manage to add them into the official naming spec.

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

the GLIB part is fixed (in the sense that now the only thing that's missing is icons)

interested people can follow here: https://bugs.launchpad.net/bugs/387969

Changed in xdg-user-dirs (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Looks like this is well on its way to being fixed. Ken, will you keep an eye on this one in case it needs anything from DUX?

Changed in hundredpapercuts:
assignee: nobody → Kenneth Wimer (kwwii)
status: New → Triaged
Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

Remember that the patch in glib is NOT the one with emblems (that is
to say the last screenshot I attached), so new icons are needed.

Revision history for this message
Kenneth Wimer (kwwii) wrote : Re: should apply icons to xdg-user-dirs

The first thing we would need is icons for all the places...the emblems don't fit (and would look even worse when you try to put an emblem on them).

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

Yes, in my opinion they should look like "user-home" folder

Revision history for this message
Damiano Dallatana (damidalla) wrote : Re: should apply icons to xdg-user-dirs

I do really agree with Nicolò.

That feature should not reduce the immediate impression that "Music" or "Video" are folders, not apps nor files.

* Full-size emblems w/o folder: seem to be something else (application?)
* Mimetypes: are really misleading, as they only represent a file
* Emblems: the folders keep on showing up as folders, but the emblem is not shown everywhere (not on panel, menu)
* Appropriate icons in "places": it's the most difficult possibility, but it would be perfect. Obviously, they should not be a mere "collage" of a folder and another icon: the style should be that of the home folder icon.

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

I've seen some users saying that they now have icons in nautilus.
Did someone commit a change to the icon theme, adding folder-foo?

Changed in hundredpapercuts:
milestone: none → round-1
Revision history for this message
Raul (raulr) wrote :

First, this is a very nice and colorful but eyefriendly theme, Nicolo. ;)
This should be the default theme of ubuntu.
Second, i like your opinion and this were really neutral and not persistent icons, if the emblems are embedded in the folder-icon (like your "home"-icon). i looks not persistent (like your screenshot with the emblems on the edge) and beautiful at the same time. really really nice!!
I am looking forward to see this in future ubuntu versions. ;)

Revision history for this message
Nick Sewell (nsewell2) wrote :

I like screenshot 2, but it needs more work to make it simpler. The music icon si good, but the others are too complicated, given that the detail is so small.

Desktop: 2 bars is too much detail. What was wrong with the four arrows design?
Documents: OK, but a bit too small. Maybe an A to indicate writing?
Downloads: looks too much like documents. Maybe change to a simple globe or pipe design.
Music, Pictures and Videos are OK.
Public: Too complicated, and the icon is confusing, given the 'computer' icon in nautilus. Maybe a person icon or transfer icon. One note; if users want to set up samba sharing, this will get a transfer emblem.
Templates: Maybe just the small new symbol, without the document?

Revision history for this message
Fred (eldmannen+launchpad) wrote :
Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

Noone is doing wrong, since the design is not yet started

Revision history for this message
antistress (antistress) wrote : Re: should apply icons to xdg-user-dirs

i'd really like something that would like https://bugs.edge.launchpad.net/hundredpapercuts/+bug/388570/comments/1
Please keep the folder picture as basis for xdg-user-dirs icons and add an item that would mean video/picture/document etc.

Revision history for this message
Fred (eldmannen+launchpad) wrote :

Okay, but your mockups are bad (I hope you do not take any offense, because its a great idea!).
screenshot 1 - you use emblems. emblems should be attached to files/folders, not used as folders.
screenshot 2 - you use the file icons from mime type, that is very confusing.
screenshot 3 - you're on the right track here.

antistress,
wow that is pretty!

Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 126103] Re: should apply icons to xdg-user-dirs

The mockups that I've proposed were only a temporary solution. now
that the patch is accepted into glib we should draw complete icons:
as I suggested, reporting from what developer say in the upstream bug,
the icons should not use emblems, but should be designed as the
"user-desktop" icon, or "user-home"

summary: - should apply icons to xdg-user-dirs
+ Default folders inside Home Folder (e.g. Documents, Music) should have
+ special icons/emblems
Kenneth Wimer (kwwii)
Changed in hundredpapercuts:
milestone: round-1 → round-2
Kenneth Wimer (kwwii)
Changed in hundredpapercuts:
milestone: round-2 → round-3
Revision history for this message
Nicolò Chieffo (yelo3) wrote :

I removed all screenshots and old patches, so I left only the patch that was accepted upstream, so subscribers won't get confused.

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

If you want an inspiration the Breathe icon theme already have them. See the screenshots

Revision history for this message
Vish (vish) wrote :

@Nicolo: , Actually the Humanity icon set already has them ;p , which Ubuntu is considering for Karmic>
https://wiki.ubuntu.com/Artwork/Incoming/Karmic/elebuntu_Icons

tags: added: needs-artwork
Revision history for this message
Danielle Foré (danrabbit) wrote :

Already done! This papercut doesn't affect humanity :D

Changed in humanity:
assignee: nobody → Daniel Fore (daniel-p-fore)
status: New → Fix Released
Mat Tomaszewski (mat.t.)
Changed in hundredpapercuts:
importance: Undecided → Medium
Revision history for this message
Kenneth Wimer (kwwii) wrote :

Considering the number of folders with orange/white emblems already on them, I admit that using emblems is the right way to go (for the human theme, in the current state/age).

Revision history for this message
Danielle Foré (danrabbit) wrote : Re: [Bug 126103] Re: Default folders inside Home Folder (e.g. Documents, Music) should have special icons/emblems

Does this mean you want me to make changes in Humanity, or this only
about Human?

Best Regards,

Daniel Foré

http://www.elementary-project.com

On Wed, Jul 22, 2009 at 6:48 AM, Kenneth Wimer<email address hidden> wrote:
> Considering the number of folders with orange/white emblems already on
> them, I admit that using emblems is the right way to go (for the human
> theme, in the current state/age).
>
> --
> Default folders inside Home Folder (e.g. Documents, Music) should have special icons/emblems
> https://bugs.launchpad.net/bugs/126103
> You received this bug notification because you are a bug assignee.
>
> Status in Humanity Icons: Fix Released
> Status in One Hundred Paper Cuts: Triaged
> Status in “human-icon-theme” package in Ubuntu: New
> Status in “xdg-user-dirs” package in Ubuntu: Fix Released
>
> Bug description:
> Binary package hint: nautilus
>
> nautilus 2.19.4-0ubuntu2
>
> now that xdg-user-dirs are available, nautilus should attach the right icon to them! And the icon should be also visible in the Places panel
>

Revision history for this message
Vish (vish) wrote :

@Daniel Fore :
The places menu, still doesnt use the xdg folders,[Karmic up-to-date.] maybe needs simlinks.

Revision history for this message
Vish (vish) wrote :

Also , there are no xdg folders for , Templates and Public.

Revision history for this message
Kenneth Wimer (kwwii) wrote :

@Daniel Fore: my comments are about Human only. Humanity already does a nice job with these icons :)

My suggestion is to add overlay the existing emblems to all pixmap sizes (partially because there are already folders with emblems on them, so this follows the existing design). I have considered adding something more complex to the scalable icons, much like humanity does.

Kenneth Wimer (kwwii)
Changed in human-icon-theme (Ubuntu):
status: New → Fix Committed
Kenneth Wimer (kwwii)
Changed in hundredpapercuts:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package human-icon-theme - 0.34

---------------
human-icon-theme (0.34) karmic; urgency=low

  [ Kenneth Wimer ]
  * New release (LP: #411395)
  * Fixing mistaken index changes for fallback icons

  [ Daniel Holbach ]
  * debian/control: bump Standards-Version, no changes.

human-icon-theme (0.33.9~ppa7) jaunty; urgency=low

  * Adding xdg user dir icons at 16, 24, 48, and scalable to fix lp: #126103

human-icon-theme (0.33.9~ppa6) jaunty; urgency=low

  * Removing private icon design from open package

human-icon-theme (0.33.9~ppa5) jaunty; urgency=low

  * Adding svg and png for unr-applications-education

human-icon-theme (0.33.9~ppa4) jaunty; urgency=low

  * Adding new icon for touchscreen calibration, sysaptic and update manager

human-icon-theme (0.33.9~ppa3) jaunty; urgency=low

  * Adding gnome-display-properties in most sizes

human-icon-theme (0.33.9~ppa2) jaunty; urgency=low

  * Changing fallback from Tangerine to Humanity to fix UNR bugs shortly before release.

human-icon-theme (0.33.9~ppa1) jaunty; urgency=low

  * Adding unr-preferences-system category icon in svg and 48x48 png

human-icon-theme (0.33.8) jaunty; urgency=low

  * Adding category icons for UNR at both 48x48px as well as svgs

human-icon-theme (0.33.7) jaunty; urgency=low

  * Moving entries around in index.theme and including new 16x16 gtk-close icons to fix LP: #385903
  * Adding battery state icons for notify-osd
  * Adding larger sized category icons to make UNR look nicer

human-icon-theme (0.33.6ubuntu5) jaunty; urgency=low

  * Fixing GSM disconnected icon to fix LP: #369139

human-icon-theme (0.33.6ubuntu4) jaunty; urgency=low

  * Adding link from notification-gsm-3g-full.svg to nm-device-wwan.svg to fix LP: #362836

human-icon-theme (0.33.6ubuntu3) jaunty; urgency=low

  * Adding empty battery status icon for notifications and links to legacy names to fix LP: #361664

 -- Kenneth Wimer <email address hidden> Tue, 01 Sep 2009 06:46:21 +0200

Changed in human-icon-theme (Ubuntu):
status: Fix Committed → Fix Released
Andrew (and471)
Changed in hundredpapercuts:
status: Fix Committed → Fix Released
Revision history for this message
Michael Vittiglio (michael-vittiglio) wrote :

There should be an icon to represent any files/directories which are encrypted.

Revision history for this message
Milan Bouchet-Valat (nalimilan) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.