HPLIP

hpmud ignores *_series entries in models.dat

Bug #1853002 reported by zdohnal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
In Progress
Undecided
Unassigned

Bug Description

Hi,

there is a report in Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1772698 , which is about the user is no longer able to install HP LaserJet 2200 printer.

It is due recent changes in models.dat - you probably wanted to reduce the size of models.dat, so you began aggregating similar models into one entry - like hp_laserjet_2200_series - and the .

But the problem is that io/hpmud/model.c is not aware of such changes and still expects exact case-insensitive match - so it compares 'HP_LaserJet_2200' with "hp_laserjet_2200_series", which is not the same string and it results in no model entry is found.

The attached patch does the case-insensitive comparison of model and section on model length. Then it compares the part of section after model length with '_series'.

Would you mind adding it into the project?

Revision history for this message
zdohnal (zdohnal) wrote :
Revision history for this message
shivani mandora (shivani1708) wrote :

Hi,

Thanks for proposing the patch.
We will review it and include it in our code.

Changed in hplip:
status: New → In Progress
Revision history for this message
brian_p (claremont102) wrote :

> Thanks for proposing the patch.
> We will review it and include it in our code.

Reviewing the patch is perfectly normal and expected

If it is included in the code, will that be mentioned in the
HPLIP Release Notes? I only ask because many changes are not.

I am not expecting a response.

--
Brian.

Revision history for this message
zdohnal (zdohnal) wrote :

I'm sorry I made a mistake in previous patch, here is the correct one.

Revision history for this message
zdohnal (zdohnal) wrote :

By the way, it seems launchpad is getting timeout errors recently, it is now second time when I got launchpad timeout before entering the comment.

Revision history for this message
zdohnal (zdohnal) wrote :

I updated patch because I found out other place where model names mismatched because of 'series' or 'hp_' strings.

Revision history for this message
zdohnal (zdohnal) wrote :

I'm sorry, the previous patch has a typo - here is the fixed patch.

Revision history for this message
zdohnal (zdohnal) wrote :

Updated patch - the previous one depended on uninitialized value... :(

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.