'hp-uiscan -h' crashes with traceback

Bug #1810943 reported by zdohnal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Fix Committed
Undecided
Unassigned

Bug Description

Hi,

I tried to run hp-uiscan on my Fedora before I package it, so I tried to run the script with '-h' to see what the tool does and what options it has and the tool crashed with traceback:

[user@localhost hplip]$ hp-uiscan -h

HP Linux Imaging and Printing System (ver. 3.18.12)
Scan Utility ver. 2.2

Copyright (c) 2001-15 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

Traceback (most recent call last):
  File "/usr/bin/hp-uiscan", line 31, in <module>
    opts, device_uri, printer_name, mode, ui_toolkit, lang=mod.parseStdOpts()
  File "/usr/share/hplip/base/module.py", line 430, in parseStdOpts
    self.usage(show_usage, error_msg)
  File "/usr/share/hplip/base/module.py", line 462, in usage
    utils.format_text(self.usage_data, show_usage, self.title, self.mod, self.version)
  File "/usr/share/hplip/base/utils.py", line 1664, in format_text
    for line in text_list:
TypeError: 'NoneType' object is not iterable

hp-uiscan does not have any definition of self.usage_data, so it gives traceback. I'm attaching the patch which creates basic help message and eliminates traceback. Would you mind adding it to the project?

Thank you in advance and have a nice day,

Zdenek
RHEL/Fedora hplip's maintainer

Tags: patch
Revision history for this message
zdohnal (zdohnal) wrote :
Revision history for this message
Umesh Mahindrakar (umesh.mahindrakar) wrote :

Hi Zdenek,

We have incorporated changes from the bug
https://bugs.launchpad.net/hplip/+bug/1822573

Thanks,
Umesh

Changed in hplip:
status: New → Fix Committed
Revision history for this message
Umesh Mahindrakar (umesh.mahindrakar) wrote :

Hi Zdenek,

We cannot incorporate your changes as help message is related to hp-scan not hp-uiscan.
You can see these changes in next release.

Thanks for find out the bugs and providing proposed solution.

Thanks,
Umesh

Revision history for this message
zdohnal (zdohnal) wrote :

Hi Umesh,

that's okay, you applied my newer patch, which is sufficient.

Thank you!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.