HPLIP

Choosing PPD in Setup Fails

Bug #1810058 reported by Vasthu on 2018-12-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	HPLIP	New	Undecided	Unassigned

Bug Description

When PPD autodetection fails and you had browsed to select a PPD, the input box remains as "(Not Found. Click browse to select a PPD file)".

Version: 3.18.6 (the problematic file is the same as in 3.18.12)
System: Archlinux

Expected behaviour:
1. Run hp-setup
2. Automatic discovery or manually specify printer
3. Select device from list
4. Setup cannot match PPD file from device name
5. Click the <OtherPPDButton> to browse for file
6. Choose any available file (although it's best to choose a correct one)
7. Click "Add Printer"

Actual behaviour:
1. Run hp-setup
2. Automatic discovery using "mDNS/Bonjour" for "Network/Ethernet/Wireless"
3. Choose "HP Envy 4520 Series"
4. Setup cannot match PPD file from device name
5. Click the <OtherPPDButton> to browse for file
6. Choose "/usr/share/ppd/HP/hp-envy_4520_series.ppd.gz"
7. Cannot click "Add Printer"

Revision history for this message

Vasthu (vasthu-sya) wrote on 2018-12-29:

QFileDialog.getOpenFileName returns a tuple Edit (753 bytes, text/plain)

Revision history for this message

brian_p (claremont102) wrote on 2018-12-30:

You will be told by upstream that Arch Linux is not supported by HPLIP, so you are left to the tender mercies of people like me. :)

As it happens, I have an Envy 4520 Series device. What is your CUPS version?

--
Brian.

Revision history for this message

brian_p (claremont102) wrote on 2018-12-31:

I realise now the purpose of the original post was to propose a patch and not to ask for help. Apologies for the noise.

--
Brian.

Revision history for this message

Vasthu (vasthu-sya) wrote on 2019-01-01:

I don't think it's a CUPS issue, but I'm running CUPS 2.2.10.

It's just mishandling the return type of QFileDialog.getOpenFileName.
The current HPLIP code expects it to return a file path,
but PyQt5 returns a tuple of (file path, file filter).

Example:

[user@hp-4nz54pa ~]$ python
>>> from PyQt5 import QtGui, QtWidgets
>>> a = QtWidgets.QApplication(['python'])
>>> QtWidgets.QFileDialog.getOpenFileName()
('/home/user/Documents/notes.txt', 'All Files (*)')

The only other place I see that might have the same problem is in:
ui5/fabwindow.py ImportAction_triggered
To import Fax address book, but who uses Fax these days :)

Revision history for this message

brian_p (claremont102) wrote on 2019-01-04:

> I don't think it's a CUPS issue,...

I didn't think it was but thought you were unable to print. In which case, this could help:

https://bugs.launchpad.net/hplip/+bug/1810031

--
Brian.