GTG

Sub-task arrows are reversed in RTL

Bug #412578 reported by Shahar Or
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Unassigned
GTG 0.2 "Gorignak"

Bug Description

Dear friends,

Screen shot attached to show it. The arrows should point left.

BTW, RTL means right-to-left.

Many blessings.

Tags: rtl
Revision history for this message
Shahar Or (mightyiam) wrote :
Bertrand Rousseau (bertrand-rousseau)
Changed in gtg:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

This is indeed something we didn't think about.

Open question : is there a way for us to know if the current locale is RTL or LTR ? As soon as I have that answer, I will fix this bug, it would be a simple "If" in the code.

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
importance: Low → High
milestone: none → 0.2
Bertrand Rousseau (bertrand-rousseau)
Changed in gtg:
assignee: Lionel Dricot (ploum) → nobody
importance: High → Low
milestone: 0.2 → 0.3
Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Ooops, it seems we had a collision on this. Restoring your settings...

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
importance: Low → High
milestone: 0.3 → 0.2
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Yep, I mark that kind of bug as high because it deeply impact default usability for some users.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

This is fixed in rev. 321. Could you test it in trunk ?

Warning : the arrow is decided based on your locale (widget.get_direction) not based on the content of the task (it would be then pango.find_base_dir but as we don't have the text yet when you press enter, we cannot use it)

Changed in gtg:
status: Confirmed → Fix Committed
Revision history for this message
Shahar Or (mightyiam) wrote :

Dear Lionel,

It does change the direction to point left now. Howerver, it always points left, as you've said. Even if my subtask is LTR.

So whatever you decide.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Shahar : I agree that current situation is sub-optimal but it seems really difficult to do it better right now. If you found someone expert about RTL questions in GTK.TextView, ask him to contact us and we will try to solve the problem together.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

The fix has been reverted in rev 316.1.17

Changed in gtg:
status: Fix Committed → Confirmed
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Luca reverted that, thanks Luca

Changed in gtg:
status: Confirmed → Fix Committed
Luca Falavigna (dktrkranz)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.