quickadd doesnt apply tags present in title

As a workaround, what you can do currently is to select the tag in the sidebar then quickadd your task. The selected tag will be applied automatically

Moreover, if you add the task : "some task @sometag"

Then the final name of the task should be : "some task sometag" and the task description should contain @sometag

I agree with this idea but, just like that, it disallow to do something like "Dinner with @Delphine". Perhaps using a separator between the task name and tags like "Dinner with @Delphine, @tag1 @tag2". That add an non intuitive coma but open possibilities.

please, no such syntax...

Why is the "Dinner with Delphine" not appropriate for a task name ?

Or perhaps the special prefixing character (@) should be configurable ? (for advanced user, at least...)

Le jeudi 19 mars 2009 à 20:29 +0000, hbernard a écrit :
> please, no such syntax...
>
> Why is the "Dinner with Delphine" not appropriate for a task name ?
>
> Or perhaps the special prefixing character (@) should be configurable ?
> (for advanced user, at least...)
>

The problem is that, with the idea of the original post, "Dinner with
@Delphine" become "Dinner with" and @Delphine move in the task text.

It is also possible to write "Dinner with Delphine @Delphine" and that's
more compatible with tag groups if bug #321903 is fix.

I didn't mean this...

Please read again :

if you add the task : "some task @sometag"

Then the final name of the task should be : "some task sometag" and the task description should contain @sometag

I attach a patch which make that "Dinner with @Delphine and @Thomas, @today @sometag" become "Dinner with Delphine and Thomas" and tags are @Delphine, @Thomas, @today and @sometag.

great, I'm going to try your patch ASAP.

Thanks !

2009/3/21 Pititjo <email address hidden>:
> I attach a patch which make that "Dinner with @Delphine and @Thomas,
> @today @sometag" become "Dinner with Delphine and Thomas" and tags are
> @Delphine, @Thomas, @today and @sometag.
>
> ** Attachment added: "Add tag support in quickadd"
>   http://launchpadlibrarian.net/24168000/quickadd.patch
>
> --
> quickadd doesnt apply tags present in title
> https://bugs.launchpad.net/bugs/340510
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Unfortunatly, this patch cannot be accepted for one good reason : you should be able to have comma in your title.

Try : "Yes, it will work" and the task would be "yes", which is, I think, not what we want (but I'm open to justification about that).

I believe we should do it simple : we should strip out all tags from the title or we should keep them all. The comma stuff is disturbing. For now, I would say : just keep the title as it is and apply tags.

(Nice to know that we have a re hacker in the community, I hate regexp)

A new patch witch witch keep and apply all tags.

This is not my favorite behavior because if I want to add a @someday tag, for example, I don't want it in my task title but if I write "Dinner with @Delphine" I want to keep the "Delphine".

Perhaps we can do that with an another separator ?

Or adding a new concept. For example tags with two @ at the beginning will be strip out. "Dinner with @Delphine @@someday" could become "Dinner with Delphine". This sound a little bit complicated for user and less practical as coma but it can work.

On Thu, Mar 26, 2009 at 9:27 AM, Pititjo <email address hidden> wrote:
> A new patch witch witch keep and apply all tags.
>
> This is not my favorite behavior because if I want to add a @someday
> tag, for example, I don't want it in my task title but if I write
> "Dinner with @Delphine" I want to keep the "Delphine".
>
> Perhaps we can do that with an another separator ?
>
> Or adding a new concept. For example tags with two @ at the beginning
> will be strip out. "Dinner with @Delphine @@someday" could become
> "Dinner with Delphine". This sound a little bit complicated for user and
> less practical as coma but it can work.

I don't like this behaviour, this is quite complicated and unexpected
for the user. I would prefer something like this: use a keyword+':'.
Like tags:Delphine,someday This could be further augmented with other
keywords (defer:DDMMYYYY,end:DDMMYYYY, etc.). As those would be some
kind of 'commands' addressed to the parser they should be retrieved
from the string and not be part of the title.

> ** Attachment added: "New patch for tags in quickadd, keep all tags"
>   http://launchpadlibrarian.net/24358295/quickadd.patch
>
> ** Tags added: toreview
>
> --
> quickadd doesnt apply tags present in title
> https://bugs.launchpad.net/bugs/340510
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for gtg.
>
> Status in Getting Things Gnome!: Confirmed
>
> Bug description:
> Using quickadd to add a task like: "some task @sometag" won't apply the tag sometag to it.
> But opening it with task editor and closing it immediately applies the tag.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

I like the command behavior. So "Dinner with @Delphine tags:someday" become "Dinner with Delphine" and tags are Delphine and someday.

I implement that right now.

I suggest this:

"Eating @@dinner with @@Mary, @@Andreas and @@Mike @food @wine @beer @restaurant" => "Eating dinner with Mary, Andreas and Mike"

Using "tags:sometag someothertag" etc would be quite bad since we would have to localize that in order to make users feel comfortable with the application. As an example, "Tags" translates to "Ettiketter" in swedish - which is a quite long word to type for each task.

As you say on IRC it can work if commands are auto-completed.

Yes, please disregard my dissing of the commands(attributes) approach. :-)

It's good because:

- Intuitive through discoverability. (Just type du and get "due" suggested).
- Good data structure, which is a plus for the devs implementing this.
- Easy adding/removing of attributes.
- Being able to localize it would make it even more natural to the user. Way better than separators.
- It is non-intrusive. The user can go ahead and create normal tasks without ever knowing of this interface.

how would you make auto-suggestion of commands work ?

I mean, if you just type "ta", how woud gtg knows that you are keying command "tags" or just the beginning of "talentuous" (for example).

Don't we need a prefix for commands, here ?
like %tags:foo,bar, maybe ?

I join a patch witch implement the tags command with the % prefix but without localization and auto-completion yet.

> hbernard

You should only autocomplete tags if you already entered the tag command header ('tag:'). Thus I think we could actually get rid of the '%'.

> Bertrand :

I thought the discussion was about autocompletion of _commands_ ;)

> hbernard:

Ok, I understand the confusion now. We discussed this a bit on IRC and
I had in mind that autocompletion only take place when you hit <tab>.
I that case GTG doesn't try to autocomplete any word you type but only
word intended by the user as being a command. It seems none of these
aspects made it to the bug report.

On Thu, Mar 26, 2009 at 2:33 PM, hbernard <email address hidden> wrote:
>> Bertrand :
>
> I thought the discussion was about autocompletion of _commands_  ;)
>
> --
> quickadd doesnt apply tags present in title
> https://bugs.launchpad.net/bugs/340510
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for gtg.
>
> Status in Getting Things Gnome!: Confirmed
>
> Bug description:
> Using quickadd to add a task like: "some task @sometag" won't apply the tag sometag to it.
> But opening it with task editor and closing it immediately applies the tag.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

The same patch without the prefix.

Thanks Pititjo, you patch has been integrated, I made some modifications to do so.

In order to close this bug, some actions are needed:

 - open another bug for attributes autocompletion (a.k.a. 'commands', but I eventually prefer to use the word attribute)
 - open other bugs for defer: and due: attribute support

Bertrand, don't forget to add pitijo in the AUTHORS file as a contributor to 0.1.1 (all current 0.2 contributors should be moved to 0.1.1 by the way)

Oh and also to update the changelog to reflect the change

Ooops, I did it again :-s. Sorry I thought Pititjo was already in
AUTHORS. I updated CHANGELOG as well, and everyone has already been
moved to 0.1.1.

On Fri, Mar 27, 2009 at 9:23 AM, Lionel Dricot <email address hidden> wrote:
> Bertrand, don't forget to add pitijo in the AUTHORS file as a
> contributor to 0.1.1 (all current 0.2 contributors should be moved to
> 0.1.1 by the way)
>
> --
> quickadd doesnt apply tags present in title
> https://bugs.launchpad.net/bugs/340510
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for gtg.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> Using quickadd to add a task like: "some task @sometag" won't apply the tag sometag to it.
> But opening it with task editor and closing it immediately applies the tag.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Thanks :-)

I also updated the wiki to ask contributors to do that themselves in their patches.

I'm not sure it can be closed because it doesn't work at all for me.

It seem only the part of the patch witch implement the "tags" attribute has been inserted in the trunk. The detection of tags in the title out of the command context don't appear.

Is it volunteer ?

On Fri, Mar 27, 2009 at 9:35 PM, Pititjo <email address hidden> wrote:
> It seem only the part of the patch witch implement the "tags" attribute
> has been inserted in the trunk. The detection of tags in the title out
> of the command context don't appear.
>
> Is it volunteer ?

Yes, since I thought that it was decided to use attributes instead of
integrated tags in title. It seems weird for me to have two different
systems to include tags. But I can be wrong.

> --
> quickadd doesnt apply tags present in title
> https://bugs.launchpad.net/bugs/340510
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for gtg.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> Using quickadd to add a task like: "some task @sometag" won't apply the tag sometag to it.
> But opening it with task editor and closing it immediately applies the tag.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Just 0.02 € here :

- currently, if you edit the title of the task _after_ the create operation, the @foo syntax seems to work
- but when using tags during create operation, it doesn't.

this is not consistent. Please, keep in mind the initial bug report.

My daily use: Most of my tasks are mainly "reminders". I just keep things like

@fooproject : see the @planning conflict with project @bar in july
@bar : track down the @performance trouble with @bar:subcomponent (ask @vincent)

you see ? I don't need task description, and I don't want to input twice the tagged words.

Hope it helps...

Yes, I think that the default behaviour is to keep the title as entered but to add tags that this title might contain. It's the "less surprizing" behaviour and thus should be the default in order to close this bug.

Fixed in r215. The full patch from Pititjo has now been apllied. Please accept my apologies for having misunderstood the conclusion of the discussion. There is still a small modification however: the "@" are not removed. On this, I agree with Lionel that it should remain in the title sincethe words are then explicitly used as tags. If you want to add tags implicitly, you can use the tags: attribute.

merci :)