[Legacy] GNOME Activity Journal

Replace bookmark icon with something that highlights when selected

Bug #365923 reported by Ketil Wendelbo Aanensen on 2009-04-24

Affects		Status	Importance	Assigned to	Milestone
	[Legacy] GNOME Activity Journal	Fix Released	High	Seif Lotfy

Bug Description

We need a GenericCellRenderer that works as a togglebutton with a star instead of a checkbox. The bookmark icon should be grey by default, then in colour when bookmark mode is active.

See original description

Revision history for this message

Seif Lotfy (seif) wrote on 2009-04-25:

Why not use a star?

Changed in gnome-zeitgeist:
status:	New → Confirmed
importance:	Undecided → High

Seif Lotfy (seif) on 2009-04-25

description:

updated

Revision history for this message

Milan Bouchet-Valat (nalimilan) wrote on 2009-04-26:

cellrendererbookmark.tar.gz Edit (9.8 KiB, application/x-tar)

Attached is a rough implementation of that cell renderer. It's based on GtkCellRendererToggle, except that it renders the cell using a GtkCellRendererPixbuf, merely transferring function calls, and setting the star icon as appropriate. Two star icons are taken from Firefox (what license exactly?).

Untested, but simple enough to be fixed in situation. I guess it should be integrated into the rest of the project to check that it works, else testing would be a useless pain.

Seif Lotfy (seif) on 2009-05-01