Xv does not work

And this is a better patch (non-inverted)

Thank you very much Yves, I'll see if I can release a package with it in the next couple of hours.

It works well! Great!
I've applied the patch removing the old xvtempfix.patch

Only one problem during compiling was the first if statement in include:
+#if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION) < 6
 #include "xf86Resources.h"
+#endif
I had to remove it and everything went ok (don't know why ABI check doesn't work)

I put the new xserver-xorg-video-psb package in my repository because it was quicker to reach,
now that i'm sure it works i could copy to gma500/ppa. let me know.

and thanks again Yves!!!

i left cheese-webcam open when i was writing my previous post and now
i find only a black screen.. ugh.. it worked only for 5 min.
well.. better than nothing!
tested also totem and beside playback is a bit slow it works properly.

another update:
adobe flash in fullscreen mode is still white.

here is updated bzr code
https://code.launchpad.net/~lucazade

and my ppa
https://launchpad.net/~lucazade/+archive/psb

OK, and there is an offset here when I open cheese. It does continue to play here for at least 20 minutes now. Maybe you have the offset too and it is moved offscreen ?

In any case, it needs more debugging.

-Yves

Yes, there is an offset, part of image is offscreen (out of window border)
tried cheese again and after some minutes image doesn't update/resfresh (application doesn't freeze anyway)

This one should fix the offset issue.

Yves

Yes.. fixed offset and refresh.
For me bug is fixed.
I'd wait for other positive feedbacks before put in main repo.

Any way I can test this without having to download and build the whole package?

Paul

If the window is at the back, Xv-output is still on the front.

I hope to fix that too using an extra compositing step. I hope this won't take too much resources as this is an copy of the video-frame.

In any case, if I get that working too, I'll add an extra xorg.conf parameter to choose the 2 behaviors as I tend to prefer Xv-fps above some windowing artefacts.

-Yves

@Paul Dooley
use this package
https://launchpad.net/~lucazade/+archive/psb/+files/xserver-xorg-video-psb_0.36.0-0ubuntu3~1010um4_i386.deb

@Yves
yes, i've seen this issue, also moving window leaves some artefacts on desktop.
with latest patch videoplayback in totem became smooth, with first patch was a bit slow, at least this seems to me!

side note...totem in fullscreen (embeded inside chrome and firefox) makes X crash :D
so i switched to gnome-mplayer to use the flash replacer plugin.
I'll try to get some logs.

Tested using Totem, VLC, Gnome Mplayer and MythTV 0.24. All work well! No artifacts here (yet) and I can drag/move windows around without any adverse effects.

With compiz enabled performance is still good, but dragging windowed video leaves output behind...(tested using Totem)

Good work guys!

Paul
(Acer Aspire One 751h, 2 GB RAM, Ubuntu 10.10)

Driver still lacks bounds checks when you move the video-window out of the screen (and corrupts stuff when moving beyond the bottom). I have most of them now fixed. As soon as I'm finished with all the cases I'll upload a new patch.

-Yves

Lucazade: The difference between the 2 is that the second patch uses the RegionPtr to calculate the position. It cannot have any influence on performance.
My bounds-checking might fix the issues of fullscreen.

-Yves

New patch with bounds checking.

Yves

Tried new patch and packaged
It seems there are no issue moving the window out of screen and back, image is still visible w/o problems.
Only thing I can see are some artefacts moving the window inside screen (not a great issue!)

attached a screenshot

This is because I shoot the Xv directly on the framebuffer bypassing any compositing and all else, this is how Xv worked 10 years ago. It is also the fastest way.

Maybe I could redraw the part of the screen where the previous position was? We might loose some frames but hey, who watches video while dragging its window and will complain about framedrop?

-Yves

no one will drag the window, that's for sure!
It is only my usual stress test to take out *useless* issues.. for me it is perfect as is now!

works for me. i made a gentoo ebuild out of this over here: bugs.gentoo.org # 338330 . thanks!

Status changed to 'Confirmed' because the bug affects multiple users.

The attachment "Fix for Xv support" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]