Bazaar

bzr push should not work by default if there are uncommited changes

Bug #65286 reported by Tim Penhey
4
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Vincent Ladeuil
Bazaar 1.17 "so-late-its-brunch"

Bug Description

I just came across this while working.

bzr push came back with:
0 revision(s) pushed.

Obviously what I wanted to do was push changes (which were still uncommitted).

So needed to commit first. Just suggesting that perhaps by default push should fail if there is uncommitted work.

I can't think of any situations where you would want to push a branch while there is uncommitted work, but someone may - perhaps forcable with --force.

Tags: mysql

Related branches

lp:~vila/bzr/284038-push-strict
John A Meinel: Approve
bzr-core: Pending requested
Diff: 155 lines
lp:~vila/bzr/integration
Vincent Ladeuil: Approve
Diff: 31 lines (+4/-4)
2 files modified
bzrlib/lazy_regex.py (+3/-3)
doc/en/release-notes/bzr-2.7.txt (+1/-1)
John A Meinel (jameinel)
Changed in bzr:
importance: Undecided → Wishlist
status: Unconfirmed → Confirmed
Revision history for this message
Martin Pool (mbp) wrote :

See also bug 206577 asking for this to be done for bzr send, and mysql bug 322808.

Changed in bzr:
importance: Wishlist → Medium
summary: - bzr push should not work by default if there are uncommited changes
+ bzr push and bzr send should should not work by default if there are
+ uncommited changes
summary: - bzr push and bzr send should should not work by default if there are
- uncommited changes
+ bzr push should not work by default if there are uncommited changes
tags: added: mysql
Revision history for this message
Martin Pool (mbp) wrote :

pqm-send apparently does this check already; it should be unified.

Vincent Ladeuil (vila)
Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
status: Confirmed → In Progress
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 1.17
status: In Progress → Fix Committed
Revision history for this message
John A Meinel (jameinel) wrote :

So I can certainly think of cases, like pushing up what I'm working on before I switch to commit my changes to a different branch. I won't say it is the more common case, but it is a clear use case for having the ability to push when there are uncommitted changes.

Revision history for this message
John A Meinel (jameinel) wrote :

I should also mention that "pqm-submit" (IMO) is a much stronger action, as it is "merge this into the final product", which is has a different set of implications than "make this work public for someone else to get". Anyway, I'm very happy to have a flag for it, just pointing out places where it isn't exactly like what 'pqm-submit' does today.

Revision history for this message
Vincent Ladeuil (vila) wrote : Re: [Bug 65286] Re: bzr push should not work by default if there are uncommited changes

>>>>> "jam" == John A Meinel <email address hidden> writes:

    jam> So I can certainly think of cases, like pushing up what
    jam> I'm working on before I switch to commit my changes to a
    jam> different branch.

Same here.

    jam> I won't say it is the more common case, but it is a
    jam> clear use case for having the ability to push when there
    jam> are uncommitted changes.

I always thought so. Yet, for *new* users, that behavior will be
surprising (I know it has been for me, long ago).

So I understand the rationale for making it the default.

Yet, like you, I certainly want to be able to override it, that's
why I added configurations variables in addition to the
command-line option, as soon as I begun working on the bug.

Vincent Ladeuil (vila)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.