null output from test script matches anything

Bug #637830 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Martin Pool

Bug Description

This passes:

        run_script(self, """
        $ echo foo
        """)

I don't think it should. If you don't care about the output of the command, you should say '...'.

It's pretty confusing if you write that, expect it to fail, and it doesn't.

Related branches

Martin Pool (mbp)
Changed in bzr:
assignee: nobody → Martin Pool (mbp)
status: Confirmed → In Progress
Revision history for this message
Martin Pool (mbp) wrote :

OK, fixed in the attached branch.

This is going to put on a slight extra burden that you need to think about commands that may produce output, and if we change a command that is initially silent to produce output, we may need to update a bunch of tests. However I think this is much safer than not letting people check things actually are silent.

Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 2.3b3
status: In Progress → Fix Released
Vincent Ladeuil (vila)
Changed in bzr:
milestone: 2.3b3 → 2.3b4
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.