smart transport test failure if paramiko is not insalled

Bug #62727 reported by Martin Pool
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Martin Pool

Bug Description

A test fails if Paramiko is not available:

> ======================================================================
> ERROR: test_registration (bzrlib.tests.test_smart_transport.SmartTransportRegi\ stration)
>
> vvvv[log from bzrlib.tests.test_smart_transport.SmartTransportRegistration.tes\ t_registration]
>
> ^^^^[log from bzrlib.tests.test_smart_transport.SmartTransportRegistration.tes\ t_registration]
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzrlib/tests/test_smart_tran\ sport.py", line 280, in test_registration
> t = get_transport('bzr+ssh://example.com/path')
> File "/net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzrlib/transport/__init__.py\ ", line 1017, in get_transport
> t, last_err = _try_transport_factories(base, factory_list)
> File "/net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzrlib/transport/__init__.py\ ", line 1033, in _try_transport_factories
> return factory(base), None
> File "/net/ecrins/local/moy/usr/src/bzr/bzr.dev/bzrlib/transport/__init__.py\ ", line 99, in _loader
> klass = getattr(mod, classname)
> AttributeError: 'module' object has no attribute 'SmartSSHTransport'

Martin Pool (mbp)
Changed in bzr:
status: Unconfirmed → Confirmed
Revision history for this message
Martin Pool (mbp) wrote :

I can confirm this is a bug.

Apparently Andrew's branch fixes this so I'll leave it for now.

One part of the problem is that the ParamikoNotPresent exception is
absorbed by bzrlib.transport.smart. But at a deeper level, the smart
transport shouldn't depend on paramiko, unless it's unable to find any
other ssh implementation.

Revision history for this message
Martin Pool (mbp) wrote :

assign to andrew

Changed in bzr:
assignee: nobody → spiv
importance: Undecided → Medium
Revision history for this message
Martin Pool (mbp) wrote :

fixed, will send for review

Changed in bzr:
assignee: spiv → mbp
status: Confirmed → Fix Committed
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.