lp-propose redirected me to a page which had a leading '1.0'
Bug #619412 reported by
Guilherme Salgado
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Unassigned | ||
launchpadlib |
Invalid
|
Undecided
|
Unassigned |
Bug Description
I've just used lp-submit to submit a branch and after it was done it redirected me to https:/
summary: |
- lp-submit redirected me to a page which had a leading '1.0' + lp-propose redirected me to a page which had a leading '1.0' |
tags: | added: lp-propose |
To post a comment you must log in.
I think the recommended name is actually 'lp-propose' now, but it does still have 'lp-submit' as an alias.
Anyway, the issue is probably in: url(object) :
str(object. self_link) ) path.split( '/')[2: ]) replace( 'api.', 'code.') urlunparse( (scheme, netloc, path, params, query,
fragment) )
def canonical_
"""Return the canonical URL for a branch."""
scheme, netloc, path, params, query, fragment = urlparse.urlparse(
path = '/'.join(
netloc = netloc.
return urlparse.
The issue being that 'self_link' is an api.... style url, but that isn't useful for opening a web browser.
In other code in bzr (or hydrazine?) I've seen "url.replace( 'api.launchpad. net/1.0' , 'code.launchpad .net')"
Regardless, I think the *real* fix is to have Launchpad api objects give you a url that you can give to users, rather than trying to fake it in the wrapper code.
I think this can be fixed here, but I think it is also a launchpadlib issue, so I'll add that project.