repository_implementations.test_vfat* is broken.

a TODO from the mailing list..

>> Something is wrong with the test. I forced it to fail and I inspected
>> the test directories.
>>
>> And I saw that all of them are using Knit1 format repositories.
>>
>> I think the specific problem is that you are inheriting from
>> TestCaseWithTransport, rather than TestCaseWithRepository.
>
> Ah. I shall look. I think the right thing to do is to have it provide
> explicit exceptions for the known bad formats, and force all new
formats
> to be safe.
>
> How does that sound?
> Rob

+1 to me.

It so happens that the only safe one should be Knit1. :) But as we get
new formats, we should deal with it.

I think we should have the test include a revision id with ':' as well.
Since we get them from Arch and SVN conversions.

I also think there is some overlap with
repository_implementations/test_fileid_involved.py

But I think this is a more explicit test for it, so I'm happy enough to
see it.

John
=:->

 affects /products/bzr
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.