reconfigure --unstacked doesn't quite work for lp branches
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Andrew Bennetts |
Bug Description
I pushed up a test branch which is unrelated to trunk
$ bzr push
Using saved push location: lp:~thumper/wikkid/sandbox
Using default stacking branch /~wikkid/
Created new stacked branch referring to /~wikkid/
HPSS calls: 21 (0 vfs) SmartSSHClientM
Now I tried to unstack it:
tim@elwood:
bzr+ssh:
bzr: ERROR: Lock not held: RemoteRepositor
HPSS calls: 22 (9 vfs) SmartSSHClientM
HPSS calls: 11 (6 vfs) SmartSSHClientM
It's straightforward to reproduce. The traceback in ~/.bzr.log looks like:
Traceback (most recent call last):
File "/home/
return the_callable(*args, **kwargs)
File "/home/
ret = run(*run_argv)
File "/home/
return self.run_
File "/home/
return self._operation
File "/home/
self.cleanups, self.func, *args, **kwargs)
File "/home/
result = func(*args, **kwargs)
File "/home/
reconfigure
File "/home/
branch.unlock()
File "/home/
return unbound(*args, **kwargs)
File "/home/
self.
File "/home/
return unbound(*args, **kwargs)
File "/home/
return lock.cant_
File "/home/
raise errors.
LockNotHeld: Lock not held: RemoteRepositor
Related branches
- John A Meinel: Approve
-
Diff: 168 lines (+89/-23)3 files modifiedNEWS (+3/-0)
bzrlib/branch.py (+47/-19)
bzrlib/tests/per_branch/test_stacking.py (+39/-4)
tags: | added: hpss launchpad reconfigure stacking |
Changed in bzr: | |
assignee: | nobody → Andrew Bennetts (spiv) |
Changed in bzr: | |
milestone: | none → 2.2.0 |
This seems likely to be a fairly shallow bug in Branch._unstack. At a glance the old_repository. unlock calls appear unbalanced.
Thanks for the report.