Bazaar

bzr-explorer don't work if installing by bzr-2.1.0 standalone installer.

Bug #524162 reported by IWATA Hidetaka
34
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Ian Clatworthy
Bazaar 2.1.1
Bazaar Explorer
Invalid
Undecided
Unassigned
Bazaar Windows Installers
Fix Released
Critical
Ian Clatworthy

Bug Description

I installed bzr-explorer from bzr-2.1.0 windows standalone installer.
> http://launchpad.net/bzr/2.1/2.1.0/+download/bzr-2.1.0-1-setup.exe

Then
 * Menu bar is not shown.
 * Selecting File(&F) > Accessories will crash.

In bazaar\plugins\explorer, these files does not exist. This maybe cause this probrem.
 * skin\editors.conf
 * skin\toolbars.xml

Related branches

lp:~ian-clatworthy/bzr-windows-installers/py2exe-local-support
lp:~ian-clatworthy/bzr/plugin-packaging-524162
Martin Pool: Approve
Diff: 47 lines (+9/-3)
2 files modified
NEWS (+2/-0)
setup.py (+7/-3)
Revision history for this message
Martin Pool (mbp) wrote :

This is a known bug in packaging.

Changed in bzr:
importance: Undecided → Critical
status: New → Confirmed
milestone: none → 2.1.1
tags: added: packaging win32
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

The problem is in the Windows packaging, not explorer itself.

Changed in bzr-windows-installers:
assignee: nobody → Ian Clatworthy (ian-clatworthy)
importance: Undecided → Critical
status: New → Confirmed
Changed in bzr-explorer:
status: New → Invalid
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

As an immediate work-around, perhaps we can comment out the 2 lines in setup.py that are skipping files inslde plugins based on their extension?

The next step after that is to copy all the py2exe-related content out of setup.py inside bzr and move it into the installer project. build-installer.bat can call something other than setup.py to execute the logic it needs.

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

The linked branch has my progress so far on this, namely migrating the setup.py py2exe logic (from bzr's setup.py) to a new script/class in the Windows Installer project. That script/class needs to be hooked in and tested. I'm hoping John can have a go at that in the coming hours as I need to sleep now.

FWIW, I've also started work on migrating build-installer.bat.in to build-installer.py.in: I find the bat script template very hard to change and debug. Again it's yet to be tested and debugged but it may help get this (and follow-on improvements) working sooner.

Changed in bzr-windows-installers:
assignee: Ian Clatworthy (ian-clatworthy) → John A Meinel (jameinel)
Changed in bzr:
assignee: nobody → John A Meinel (jameinel)
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Also, if we remove the dependence on bzr's setup.py completely, then we don't need a 2.1.1 in order to get this fixed.

In any case, we certainly need a new installer made available ASAP given the various issues uncovered in testing: this one, news-merge plugin missing and old chm files.

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

John,

Is my branch heading in the right direction? Or should we just comment out the two lines in setup.py inside bzr causing the files to be omitted for now?

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

After discussions with poolie today, I'll take on responsibility for getting this fixed and getting a new Windows installer built ASAP.

Changed in bzr-windows-installers:
assignee: John A Meinel (jameinel) → Ian Clatworthy (ian-clatworthy)
Changed in bzr:
assignee: John A Meinel (jameinel) → Ian Clatworthy (ian-clatworthy)
Ian Clatworthy (ian-clatworthy)
Changed in bzr-windows-installers:
status: Confirmed → Fix Released
Revision history for this message
Martin Pool (mbp) wrote :

> It's waiting on https://code.edge.launchpad.net/~ian-clatworthy/bzr/plugin-packaging-524162/+merge/20858 being reviewed and landed

Changed in bzr:
status: Confirmed → In Progress
Revision history for this message
Martin Pool (mbp) wrote :

Ian's fix is merged so I think this is fixreleased and will be ok in 2.1.1.

Changed in bzr:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.