run_bzr() fails unless you set a ui factory

Easy to do, but the question is: should the default be to silently absorb the output, or to write it to stdout? Or maybe the default should actually be a text uifactory?

On Wed, 2009-12-23 at 00:23 +0000, Martin Pool wrote:
> Easy to do, but the question is: should the default be to silently
> absorb the output, or to write it to stdout? Or maybe the default
> should actually be a text uifactory?

The older behaviour would have written to stdout; the ui factory at
those times simply meant 'no progress bar'. FWIW that behaviour seemed
to make folk happy.

-Rob

Robert Collins wrote:
> On Wed, 2009-12-23 at 00:23 +0000, Martin Pool wrote:
>> Easy to do, but the question is: should the default be to silently
>> absorb the output, or to write it to stdout? Or maybe the default
>> should actually be a text uifactory?
>
> The older behaviour would have written to stdout; the ui factory at
> those times simply meant 'no progress bar'. FWIW that behaviour seemed
> to make folk happy.

I think I agree with this -- output to stdout by default makes sense.
Probably erroring if input is requested is fine.

Cheers,
mwh

ok, and with the new uifactory code, we should automatically make a
sensible decision about whether to show progress bars or not, with no
special intervention. Just calling
make_uifactory_for_stream(sys.stdout) should be enough. Want to try
it, mwh?

--
Martin <http://launchpad.net/~mbp/>

Calling

ui.ui_factory = ui.make_ui_for_terminal(sys.stdin, sys.stdout, sys.stderr)

makes it work as I expected, yes.

bzrlib.initialize must be called before using the library, and it will create a UI by default.

imbn to just do this at import time, but callers need a chance to provide arguments and it's a bit hard to implement.