Launchpad plugin is not compatible with python-2.4 in bzr 2.1.0b2

Bug #475585 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Vincent Ladeuil

Bug Description

Reported by Martin (gzlist):
I've had various problems with launchpad today, at least one of them
is bazaar's fault. Python 2.4 is broken by Revision 4782, specifically
this commit:

<http://bazaar.launchpad.net/~bzr-pqm/bzr/bzr.dev/revision/4782/bzrlib/plugins/launchpad/lp_registration.py>

The new XMLRPCTransport class has:

    xmlrpclib.Transport.__init__(self, use_datetime=use_datetime)

However, xmlrpclib.Transport is a classic class, and the change that
added the __init__ method only landed for 2.5:

<http://svn.python.org/view/python/branches/release25-maint/Lib/xmlrpclib.py?r1=38462&r2=38877>

Related branches

Vincent Ladeuil (vila)
Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 475585] [NEW] Launchpad plugin is not compatible with python-2.4 anymore

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Public bug reported:
>
> Reported by Martin (gzlist):
> I've had various problems with launchpad today, at least one of them
> is bazaar's fault. Python 2.4 is broken by Revision 4782, specifically
> this commit:
>
> <http://bazaar.launchpad.net/~bzr-
> pqm/bzr/bzr.dev/revision/4782/bzrlib/plugins/launchpad/lp_registration.py>
>
> The new XMLRPCTransport class has:
>
> xmlrpclib.Transport.__init__(self, use_datetime=use_datetime)
>
> However, xmlrpclib.Transport is a classic class, and the change that
> added the __init__ method only landed for 2.5:
>
> <http://svn.python.org/view/python/branches/release25-maint/Lib/xmlrpclib.py?r1=38462&r2=38877>

Would this be a good time to make sure we have a python2.4 child in
buildbot?

I know PQM is supposed to be running python2.4, but there seems to be
some disagreement between how it should be configured. Canonical's IT
wants us to create a new 'make' target, rather than configuring pqm's
environment.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrzCCQACgkQJdeBCYSNAAPxdwCgvpOu9rbVEjZ4zgTyYkmDmjw+
9LoAoM2fa1L5YkToZEy9sDo4nuoRExHa
=Mezk
-----END PGP SIGNATURE-----

Revision history for this message
Vincent Ladeuil (vila) wrote : Re: Launchpad plugin is not compatible with python-2.4 anymore

We should certainly add an explicit python2.4 run somewhere in babune, but I won't be able to do that in the next couple of weeks.

Changed in bzr:
status: Confirmed → Fix Committed
Revision history for this message
Vincent Ladeuil (vila) wrote :

I committed a fix, but between lp http problems and my own internal network problems, I'm not even sure I will be able to make the merge proposal.

John, since that's a regression in 2.1.0.b2, you may want to backport it ?

I daggy-fixed so that shouldn't be a problem (except for the NEWS conflicts).

Revision history for this message
John A Meinel (jameinel) wrote :

This is a critical regression that should trigger us releasing bzr 2.1.0b3 early.

Changed in bzr:
milestone: none → 2.1.0b3
John A Meinel (jameinel)
summary: - Launchpad plugin is not compatible with python-2.4 anymore
+ Launchpad plugin is not compatible with python-2.4 in bzr 2.1.0b2
Revision history for this message
John A Meinel (jameinel) wrote :

This fix will be in the 2.1.0b3 release.

Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.