smart client inconsistent about escaping of paths to the surprise of the smart server
Bug #458762 reported by
Michael Hudson-Doyle
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
High
|
Andrew Bennetts | ||
Bug Description
VFS requests put urlencoded paths on the wire, all the others don't. The server assumes urlencoded paths everywhere. Confusion results.
I have a branch that fixes this, it's missing a test of the vfs methods handling things correctly.
Related branches
lp:~spiv/bzr/escape-smart-server-requested-paths-458762
- Martin Pool: Approve
-
Diff: 134 lines6 files modifiedNEWS (+3/-0)
bzrlib/smart/request.py (+1/-1)
bzrlib/smart/vfs.py (+9/-0)
bzrlib/tests/test_smart.py (+26/-0)
bzrlib/tests/test_smart_transport.py (+3/-1)
doc/developers/network-protocol.txt (+3/-0)
| Changed in bzr: | |
| status: | New → Confirmed |
| Changed in bzr: | |
| assignee: | nobody → Andrew Bennetts (spiv) |
| importance: | Undecided → High |
| Changed in bzr: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Andrew Bennetts (spiv) wrote | #1 |
| Changed in bzr: | |
| status: | In Progress → Fix Committed |
| Changed in bzr: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix submitted for review.