1.9->2a fetch from smart server causes "unknown object type identifier 60" in bencode
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
Andrew Bennetts | ||
2.0 |
Fix Released
|
Critical
|
Andrew Bennetts | ||
Launchpad itself |
Invalid
|
Undecided
|
Unassigned |
Bug Description
I'm trying to pull lp:~johnf-inodes/bzr/ppa-doc and I reproducibly get "bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/home/
return the_callable(*args, **kwargs)
File "/home/
ret = run(*run_argv)
File "/home/
return self.run(
File "/home/
possible_
File "/home/
result = unbound(self, *args, **kwargs)
File "/home/
local=local)
File "/home/
result = unbound(self, *args, **kwargs)
File "/home/
possible_
File "/home/
_override_
File "/home/
overwrite=
File "/home/
result = unbound(self, *args, **kwargs)
File "/home/
overwrite, graph)
File "/home/
self.
File "/home/
result = unbound(self, *args, **kwargs)
File "/home/
pb=pb)
File "/home/
find_
File "/home/
result = unbound(self, *args, **kwargs)
File "/home/
pb=pb, find_ghosts=
File "/home/
self.__fetch()
File "/home/
self.
File "/home/
stream, from_format, [])
File "/home/
return self._locked_
File "/home/
src_
File "/home/
for record in substream:
File "/home/
revision = self.serialiser
File "/home/
ret = bencode.
File "_bencode_pyx.pyx", line 218, in _bencode_
File "_bencode_pyx.pyx", line 83, in _bencode_
File "_bencode_pyx.pyx", line 113, in _bencode_
ValueError: unknown object type identifier 60
Related branches
- Robert Collins (community): Approve
-
Diff: 86 lines3 files modifiedNEWS (+4/-0)
bzrlib/remote.py (+3/-2)
bzrlib/tests/per_interrepository/test_fetch.py (+38/-0)
Changed in bzr: | |
assignee: | Martin Pool (mbp) → nobody |
Changed in bzr: | |
status: | In Progress → Fix Committed |
summary: |
- bzr1.17 on launchpad streams wrong data, causes "unknown object type - identifier 60" in bencode pulling from pack into 2a repository + 1.9->2a fetch from smart server causes "unknown object type identifier + 60" in bencode |
Changed in launchpad-code: | |
status: | New → Incomplete |
Changed in bzr: | |
milestone: | none → 2.0.1 |
Changed in bzr: | |
milestone: | 2.0.1 → 2.1.0b1 |
The bad data in question is
(Pdb) p text sha1="24e9bf619 f7622fd6c363650 eca6a3fc5d79ae5 1" <email address hidden>" timestamp= "1251864386. 509" timezone= "36000" >\n<message> Update versions< /message> \n<parents> \n<revision_ ref <email address hidden>" />\n</parents> \n<properties> <property name="branch- nick">bzr. johnf</ property> \n</properties> \n</revision> \n'
'<revision committer="John Ferlito <<email address hidden>>" format="5" inventory_
however the stream is meant to be in CHK forrmat:
(Pdb) p self.serialiser chk_serializer. CHKBEncodeSeria lizer object at 0x22b8e10> remote. RemoteStreamSou rce object at 0x28bba90>
<bzrlib.
(Pdb) p self
<bzrlib.