bzr check fails on valid stacked repository isolated from fallbacks.

Bug #421845 reported by Andrew Bennetts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

Repository.check is overly zealous when checking stacked repositories. To be valid, a revision in a stacked repository needs to be streamable. It does not need all text versions in the revision to be present (just texts changed in that revision vs. the present parent inventories), but check fails a valid repository that satisfies that condition.

I've attached a patch to an existing test that demonstrates this. Run it with "./bzr selftest selftest -s bt.per_repository_reference.test_fetch test_sprout_from_smart_stacked_with_short_history.*2a"

The scenario, as should be fairly clear in the test, is a history with three revs, A,B,C. The stacked repo ought to only have rev C and inventories B,C. Check however fails trying to access a text that originates in A, and is unmodified in C (and B).

Revision history for this message
Andrew Bennetts (spiv) wrote :
Revision history for this message
Andrew Bennetts (spiv) wrote :

Also, note that check is happy when the fallbacks are available, but check ought to be clean even when they aren't.

Martin Pool (mbp)
Changed in bzr:
status: New → Confirmed
Martin Pool (mbp)
tags: added: stacking
Changed in bzr:
importance: High → Medium
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.