dirstate sometimes stores convenient file size in cache

Bug #418439 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

Looking through dirstate.py and the pyx helper post bug 415508 it does look like they sometimes store the actual on-disk size when they should probably be storing the size of the convenient form.

This may not be important as we probably don't care about the size of the canonical form of the working copy very often.

Revision history for this message
Robert Collins (lifeless) wrote :

I'm confused by the terms here:
 on-disk size
 canonical form
 convenient form

Which form is the on disk form?

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 418439] Re: dirstate sometimes stores convenient file size in cache

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I'm confused by the terms here:
> on-disk size
> canonical form
> convenient form
>
> Which form is the on disk form?
>

canonical form is the form in memory and committed to the repository
convenient form is the form on disk.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrCx4MACgkQJdeBCYSNAAOemQCffZWZ5S4BlBWHGjI+tdegcL4i
O5cAn0DNF8KiKqPghJ2RxsfhtojF5sET
=QLNs
-----END PGP SIGNATURE-----

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.