run_bzr gives a poor message when a blackbox test fails

Bug #409688 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned

Bug Description

Example:

----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mbp/bzr/409684-cherrypick/bzrlib/tests/blackbox/test_merge.py", line 387, in test_directive_cherrypick
    out, err = self.run_bzr('merge -d target directive')
AssertionError: Unexpected return code
not equal:
a = 0
b = 1

This is true but not very helpful. It would be nice if the test failure error included the error message from the underlying bzr command - there typically is one. It's not very urgent because the error typically is visible (along with a lot of other stuff) in the test log.

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 409688] [NEW] run_bzr gives a poor message when a blackbox test fails

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Public bug reported:
>
> Example:
>
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/mbp/bzr/409684-cherrypick/bzrlib/tests/blackbox/test_merge.py", line 387, in test_directive_cherrypick
> out, err = self.run_bzr('merge -d target directive')
> AssertionError: Unexpected return code
> not equal:
> a = 0
> b = 1
>
> This is true but not very helpful. It would be nice if the test failure
> error included the error message from the underlying bzr command - there
> typically is one. It's not very urgent because the error typically is
> visible (along with a lot of other stuff) in the test log.
>
> ** Affects: bzr
> Importance: Low
> Status: Confirmed
>

So yeah, it *is* in the log, but it is hard to find. The log also
usually has the traceback, which is often just as important. I've often
found it a bit harder to debug than normal tests, though, because the
information I'm looking for isn't where I expect to find it.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkp64pMACgkQJdeBCYSNAAOZaQCeP4y46ctNm3PL7SsesHqIM1cq
gcAAnAws7iOvD9bdx1RTxiIvn7OvNeP/
=YEWw
-----END PGP SIGNATURE-----

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 409688] [NEW] run_bzr gives a poor message when a blackbox test fails

2009/8/7 John A Meinel <email address hidden>:
> So yeah, it *is* in the log, but it is hard to find. The log also
> usually has the traceback, which is often just as important. I've often
> found it a bit harder to debug than normal tests, though, because the
> information I'm looking for isn't where I expect to find it.

If they fail, I think I'd like to see:

the stderr message
the traceback

Because these error codes almost always originate in an exception
inside python it should be possible to show that directly, though it
will take a little care for tests checking for a non-zero exit.

--
Martin <http://launchpad.net/~mbp/>

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.