iter_changes missing support needed for commit
Bug #347649 reported by
Robert Collins
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Robert Collins |
Bug Description
iter_changes needs to support exclude, and including the parents of
specific files, for it to be a drop-in replacement for commit's
equivalent code path.
-Rob
affects bzr
importance high
status confirmed
Related branches
lp:~bzr/bzr/faster-commit-file
Rejected
for merging
into
lp:~bzr/bzr/trunk-old
- Robert Collins (community): Needs Fixing
- Diff: 313 lines (has conflicts)
tags: | added: brisbane-core |
tags: | added: commit |
Changed in bzr: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
The problem is that commit would like to use iter_changes, but it can't if there are selected files.
1- As iter_changes is today, if you have a specific file named which is contained within a new directory, the new directory's not included in the output, so you get an invalid inventory delta.
2- There are parameters like exclude that can be given to commit but that aren't supported by iter_changes.
This is used by mark's vcs-race script, using 'bzr commit NEWFILE NEWFILE ....' and it's too slow on brisbane-core today.