iter_changes missing support needed for commit

Bug #347649 reported by Robert Collins
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Robert Collins

Bug Description

iter_changes needs to support exclude, and including the parents of
specific files, for it to be a drop-in replacement for commit's
equivalent code path.

-Rob
 affects bzr
 importance high
 status confirmed

Revision history for this message
Martin Pool (mbp) wrote :

The problem is that commit would like to use iter_changes, but it can't if there are selected files.

1- As iter_changes is today, if you have a specific file named which is contained within a new directory, the new directory's not included in the output, so you get an invalid inventory delta.

2- There are parameters like exclude that can be given to commit but that aren't supported by iter_changes.

This is used by mark's vcs-race script, using 'bzr commit NEWFILE NEWFILE ....' and it's too slow on brisbane-core today.

Revision history for this message
Martin Pool (mbp) wrote :

needed for 2.0

Changed in bzr:
milestone: none → 2.0
tags: added: brisbane-core
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

I can confirm that this has regressed in --development6-rich-root vs 1.9. See attached benchmark results.

Changed in bzr:
assignee: nobody → Ian Clatworthy (ian-clatworthy)
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :
Revision history for this message
Martin Pool (mbp) wrote :

Robert's working on this today...

Changed in bzr:
assignee: Ian Clatworthy (ian-clatworthy) → Robert Collins (lifeless)
status: Confirmed → In Progress
tags: added: commit
Revision history for this message
Robert Collins (lifeless) wrote :

This is approaching completion. So far we've landed improvements to all the apply_inventory delta functions in bzrlib to detect corruption, and I'm putting up the branch to close half of this bug now (specific files, but not yet excludes).

Changed in bzr:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.